[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14277: Enhance PartitionGraph

2019-03-22 Thread GitBox
reminisce commented on a change in pull request #14277: Enhance PartitionGraph URL: https://github.com/apache/incubator-mxnet/pull/14277#discussion_r268360799 ## File path: src/operator/subgraph/subgraph_property.h ## @@ -205,9 +204,14 @@ class SubgraphPropertyRegistry { t

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14277: Enhance PartitionGraph

2019-03-22 Thread GitBox
reminisce commented on a change in pull request #14277: Enhance PartitionGraph URL: https://github.com/apache/incubator-mxnet/pull/14277#discussion_r268360842 ## File path: src/operator/subgraph/subgraph_property.h ## @@ -205,9 +204,14 @@ class SubgraphPropertyRegistry { t

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14277: Enhance PartitionGraph

2019-03-22 Thread GitBox
reminisce commented on a change in pull request #14277: Enhance PartitionGraph URL: https://github.com/apache/incubator-mxnet/pull/14277#discussion_r268361081 ## File path: src/executor/graph_executor.cc ## @@ -1500,91 +1473,220 @@ static nnvm::Symbol PartitionGraph(const

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14277: Enhance PartitionGraph

2019-03-04 Thread GitBox
reminisce commented on a change in pull request #14277: Enhance PartitionGraph URL: https://github.com/apache/incubator-mxnet/pull/14277#discussion_r262208394 ## File path: src/operator/subgraph/subgraph_property.h ## @@ -200,7 +197,7 @@ typedef dmlc::ThreadLocalStore__REG