rondogency commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-562461420
@wkcn Big thank to Jackie for the merging work!
This is an automated
rondogency commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-545776178
@wkcn 1.6 code freeze is tomorrow, so are you ok with this one not going
into the 1.6 release? It is because none of us have time to
rondogency commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-542954858
@szha we can also copy the implementation of dmlc::registry & dlpack to
lib_api.h, but it doesn't solve the diverge problem you described.
rondogency commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-542951984
@szha Because we want to make lib_api.h self-contained without any
dependencies. The end goal is that the user will only copy lib_api.h to
rondogency commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-541985445
talked with @szha offline and we agree on putting DLTensor support to the
next PR
rondogency commented on issue #15921: dynamic custom operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-537376762
@samskalicky @wkcn @szha @junrushao1994 @eric-haibin-lin This PR is ready
for review.
c_api.cc and lib_api.h files are the most
