[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14494: [MXNet-1340][Fit API]Adding train history class

2019-03-27 Thread GitBox
roywei commented on a change in pull request #14494: [MXNet-1340][Fit API]Adding train history class URL: https://github.com/apache/incubator-mxnet/pull/14494#discussion_r269801433 ## File path: python/mxnet/gluon/estimator/estimator.py ## @@ -231,37 +221,45 @@ def fit(sel

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #14494: [MXNet-1340][Fit API]Adding train history class

2019-03-27 Thread GitBox
roywei commented on a change in pull request #14494: [MXNet-1340][Fit API]Adding train history class URL: https://github.com/apache/incubator-mxnet/pull/14494#discussion_r269788325 ## File path: python/mxnet/gluon/trainer.py ## @@ -259,6 +259,13 @@ def learning_rate(self):