stu1130 commented on a change in pull request #15282: Numpy compatible eye URL: https://github.com/apache/incubator-mxnet/pull/15282#discussion_r296040469
########## File path: src/operator/numpy/np_init_op.h ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2019 by Contributors + * \file np_init_op.h + * \brief CPU Implementation of numpy init op + */ +#ifndef MXNET_OPERATOR_NUMPY_NP_INIT_OP_H_ +#define MXNET_OPERATOR_NUMPY_NP_INIT_OP_H_ + +#include <vector> +#include <string> +#include "../tensor/init_op.h" +#include "../tensor/elemwise_unary_op.h" + + +namespace mxnet { +namespace op { + +struct NumpyEyeParam : public dmlc::Parameter<NumpyEyeParam> { + nnvm::dim_t N; + dmlc::optional<nnvm::dim_t> M; + nnvm::dim_t k; + std::string ctx; + int dtype; + DMLC_DECLARE_PARAMETER(NumpyEyeParam) { + DMLC_DECLARE_FIELD(N) + .describe("Number of rows in the output."); + DMLC_DECLARE_FIELD(M) + .set_default(dmlc::optional<nnvm::dim_t>()) + .describe("Number of columns in the output. If None, defaults to N."); + DMLC_DECLARE_FIELD(k) + .set_default(0) + .describe("Index of the diagonal. 0 (the default) refers to the main diagonal," + "a positive value refers to an upper diagonal." + "and a negative value to a lower diagonal."); + DMLC_DECLARE_FIELD(ctx) + .set_default("") + .describe("Context of output, in format [cpu|gpu|cpu_pinned](n)." + "Only used for imperative calls."); + DMLC_DECLARE_FIELD(dtype) + .set_default(mshadow::kFloat32) + MXNET_ADD_ALL_TYPES + .describe("Data-type of the returned array."); + } +}; + +inline bool NumpyRangeShape(const nnvm::NodeAttrs& attrs, + mxnet::ShapeVector* in_shapes, + mxnet::ShapeVector* out_shapes) { + const RangeParam& param = nnvm::get<RangeParam>(attrs.parsed); + CHECK_EQ(in_shapes->size(), 0U); + CHECK_EQ(out_shapes->size(), 1U); + CHECK_NE(param.step, 0) << "_npi_arange does not support step=0"; + CHECK_EQ(param.repeat, 1) << "_npi_arange only supports repeat=1, received " << param.repeat; + CHECK(param.stop.has_value()) << "_npi_arange requires stop to have a value"; + double out_size = std::ceil((param.stop.value() - param.start) / param.step); + if (out_size < 0) { + out_size = 0; + } + SHAPE_ASSIGN_CHECK(*out_shapes, 0, mxnet::TShape({static_cast<nnvm::dim_t>(out_size)})); + return true; +} + +inline bool NumpyEyeShape(const nnvm::NodeAttrs& attrs, + mxnet::ShapeVector *in_attrs, + mxnet::ShapeVector *out_attrs) { + const NumpyEyeParam& param = nnvm::get<NumpyEyeParam>(attrs.parsed); + CHECK_EQ(in_attrs->size(), 0U); + CHECK_EQ(out_attrs->size(), 1U); + nnvm::dim_t M = param.M.has_value() ? param.M.value() : param.N; + CHECK(param.N >= 0) << "negative dimensions are not allowed. N is " << param.N; + CHECK(M >= 0) << "negative dimensions are not allowed. M is " << M; + SHAPE_ASSIGN_CHECK(*out_attrs, 0, mshadow::Shape2(param.N, M)); + + return out_attrs->at(0).ndim() != 0U; +} + +template<typename xpu> +void NumpyEyeFill(const nnvm::NodeAttrs& attrs, + const OpContext& ctx, Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
