[GitHub] [incubator-mxnet] sxjscience commented on issue #16878: add micro to pearsonr

2019-11-28 Thread GitBox
sxjscience commented on issue #16878: add micro to pearsonr URL: https://github.com/apache/incubator-mxnet/pull/16878#issuecomment-559638741 My concern is that it adds the average flag and is not a mere bug fix. @ptrendx will decide whether it is suitable to be included or not. ---

[GitHub] [incubator-mxnet] sxjscience commented on issue #16878: add micro to pearsonr

2019-11-28 Thread GitBox
sxjscience commented on issue #16878: add micro to pearsonr URL: https://github.com/apache/incubator-mxnet/pull/16878#issuecomment-559609716 @leezu For this one, we may not included it in R1.6.0 since it adds new functionality. --

[GitHub] [incubator-mxnet] sxjscience commented on issue #16878: add micro to pearsonr

2019-11-21 Thread GitBox
sxjscience commented on issue #16878: add micro to pearsonr URL: https://github.com/apache/incubator-mxnet/pull/16878#issuecomment-557215468 Nice add! Could you also add the test here? https://github.com/apache/incubator-mxnet/blob/a8b31a239f5d5ed0ebff0f3be44b5e5534e0b3f5/tests/python/unitt