[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-07 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r281824733 ## File path: tests/python/gpu/test_gluon_gpu.py ## @@ -225,6 +226,54 @@ def forward(self, inpt):

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-06 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r281429171 ## File path: tests/python/gpu/test_gluon_gpu.py ## @@ -225,6 +226,54 @@ def forward(self, inpt):

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-06 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r281425950 ## File path: src/imperative/imperative_utils.h ## @@ -67,6 +67,7 @@ inline Context GetContext(const

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-06 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r281425773 ## File path: tests/python/gpu/test_gluon_gpu.py ## @@ -225,6 +226,54 @@ def forward(self, inpt):

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-06 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r281423917 ## File path: src/operator/rnn-inl.h ## @@ -28,6 +28,7 @@ #define MXNET_USE_CUDNN_RNN MXNET_USE_C

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-02 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r280624933 ## File path: src/operator/rnn-inl.h ## @@ -1362,7 +1427,9 @@ class RNNOp { std::vector x_desc_ve

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-02 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r280622901 ## File path: src/operator/rnn.cc ## @@ -106,25 +128,33 @@ static bool RNNShape(const nnvm::NodeAttr

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-02 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r280622901 ## File path: src/operator/rnn.cc ## @@ -106,25 +128,33 @@ static bool RNNShape(const nnvm::NodeAttr

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-02 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r280622695 ## File path: tests/python/gpu/test_gluon_gpu.py ## @@ -225,6 +226,54 @@ def forward(self, inpt):

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-05-02 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r280615241 ## File path: tests/python/gpu/test_gluon_gpu.py ## @@ -225,6 +226,54 @@ def forward(self, inpt):

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-04-29 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r279468159 ## File path: python/mxnet/gluon/rnn/rnn_layer.py ## @@ -214,7 +215,7 @@ def begin_state(self, batch

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14208: Add support for fast variable-length LSTM

2019-04-21 Thread GitBox
szha commented on a change in pull request #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#discussion_r277183673 ## File path: python/mxnet/gluon/rnn/rnn_layer.py ## @@ -214,7 +215,7 @@ def begin_state(self, batch