[GitHub] [incubator-mxnet] szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor

2019-03-05 Thread GitBox
szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor URL: https://github.com/apache/incubator-mxnet/pull/14315#discussion_r262787416 ## File path: include/mxnet/tuple.h ## @@ -220,6 +235,10 @@ class Tuple { * \return the ostream */

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor

2019-03-05 Thread GitBox
szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor URL: https://github.com/apache/incubator-mxnet/pull/14315#discussion_r262744359 ## File path: include/mxnet/tuple.h ## @@ -404,9 +452,11 @@ class TShape : public Tuple { } /*! \ret

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor

2019-03-05 Thread GitBox
szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor URL: https://github.com/apache/incubator-mxnet/pull/14315#discussion_r262744066 ## File path: include/mxnet/tuple.h ## @@ -404,9 +452,11 @@ class TShape : public Tuple { } /*! \ret

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor

2019-03-05 Thread GitBox
szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor URL: https://github.com/apache/incubator-mxnet/pull/14315#discussion_r262739057 ## File path: include/mxnet/tensor_blob.h ## @@ -196,6 +196,10 @@ class TBlob { CHECK(mshadow::DataTy

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor

2019-03-05 Thread GitBox
szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor URL: https://github.com/apache/incubator-mxnet/pull/14315#discussion_r262738706 ## File path: include/mxnet/tensor_blob.h ## @@ -196,6 +196,10 @@ class TBlob { CHECK(mshadow::DataTy

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor

2019-03-05 Thread GitBox
szha commented on a change in pull request #14315: [numpy] Shape support scalar tensor URL: https://github.com/apache/incubator-mxnet/pull/14315#discussion_r262728226 ## File path: include/mxnet/tensor_blob.h ## @@ -196,6 +196,10 @@ class TBlob { CHECK(mshadow::DataTy