[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-11 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274762625 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +572,891 @@ class RNNOp : public Operator{ } DType* cx_

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-11 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274762117 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +572,891 @@ class RNNOp : public Operator{ } DType* cx_

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274143236 ## File path: src/operator/rnn.cc ## @@ -97,13 +215,69 @@ The definition of GRU here is slightly different from pape

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274114931 ## File path: src/operator/rnn.cc ## @@ -97,13 +215,69 @@ The definition of GRU here is slightly different from pape

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274142661 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,891 @@ class RNNOp : public Operator{ } DType* cx_

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274114705 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,891 @@ class RNNOp : public Operator{ } DType* cx_

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274114931 ## File path: src/operator/rnn.cc ## @@ -97,13 +215,69 @@ The definition of GRU here is slightly different from pape

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274114705 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,891 @@ class RNNOp : public Operator{ } DType* cx_

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-07 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272887175 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,893 @@ class RNNOp : public Operator{ } DType* cx_

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-07 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272886744 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,893 @@ class RNNOp : public Operator{ } DType* cx_

[GitHub] [incubator-mxnet] szha commented on a change in pull request #14476: Change RNN OP to stateful

2019-03-26 Thread GitBox
szha commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r268979558 ## File path: src/operator/rnn-inl.h ## @@ -436,387 +566,897 @@ class RNNOp : public Operator{ if (param_.state_