[GitHub] [incubator-mxnet] szha commented on issue #14262: Fix NaN value comparisons in relu, max and min ops

2019-03-07 Thread GitBox
szha commented on issue #14262: Fix NaN value comparisons in relu, max and min ops URL: https://github.com/apache/incubator-mxnet/pull/14262#issuecomment-470796792 @anirudhacharya one last thing, could you measure the performance before and after this change? This change is nonetheless nec

[GitHub] [incubator-mxnet] szha commented on issue #14262: Fix NaN value comparisons in relu, max and min ops

2019-03-06 Thread GitBox
szha commented on issue #14262: Fix NaN value comparisons in relu, max and min ops URL: https://github.com/apache/incubator-mxnet/pull/14262#issuecomment-470352823 @anirudhacharya it's not about comparison. nan is not in the domain of the function.

[GitHub] [incubator-mxnet] szha commented on issue #14262: Fix NaN value comparisons in relu, max and min ops

2019-03-06 Thread GitBox
szha commented on issue #14262: Fix NaN value comparisons in relu, max and min ops URL: https://github.com/apache/incubator-mxnet/pull/14262#issuecomment-470343849 @anirudhacharya I'm not sure if relu grad should act like that. As a sanity check, consider if nan is larger than or smaller t