[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #14443: Mxnet allclose

2019-04-29 Thread GitBox
wkcn commented on a change in pull request #14443: Mxnet allclose URL: https://github.com/apache/incubator-mxnet/pull/14443#discussion_r279197851 ## File path: src/operator/contrib/allclose_op-inl.h ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #14443: Mxnet allclose

2019-04-28 Thread GitBox
wkcn commented on a change in pull request #14443: Mxnet allclose URL: https://github.com/apache/incubator-mxnet/pull/14443#discussion_r271518449 ## File path: python/mxnet/test_utils.py ## @@ -476,24 +487,70 @@ def assert_almost_equal(a, b, rtol=None, atol=None, names=('a