wkcn commented on a change in pull request #14615: Add PushAsyncPtr and
PushSyncPtr APIs in engine
URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r272046544
##########
File path: include/mxnet/engine.h
##########
@@ -206,6 +210,43 @@ class MXNET_API Engine {
int priority = 0,
const char* opr_name = nullptr,
bool wait = false) = 0;
+ /*!
+ * \brief Push an asynchronous operation to the engine.
+ * \param exec_fn_ptr Execution function, this function takes a parameter
+ * on_complete that must be called when the execution
+ * completes.
+ * \param param the parameter set on calling exec_fn_ptr.
+ * \param exec_ctx Execution context.
+ * \param const_vars The variables that current operation will use but not
+ * mutate.
+ * \param mutable_vars The variables that current operation will mutate.
+ * \param prop Property of the function.
+ * \param priority Priority of the action, as hint to the engine.
+ * \param opr_name The operator name.
+ * \param wait Whether this is a WaitForVar operation.
+ */
+ void PushAsyncPtr(AsyncFnPtr exec_fn_ptr, const std::shared_ptr<void>& param,
Review comment:
Is there any ABI compatible problem on std::vector and std::shared_ptr? I
think it is better to use pure C type parameters in the API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
