wkcn commented on issue #16881: Add TypeFlag=>string macro
URL: https://github.com/apache/incubator-mxnet/pull/16881#issuecomment-571162674
@haojin2 The reason is that the dtypes belong to mshadow, and it will be
more convenient to get the name of mshadow::dtype.
wkcn commented on issue #16881: Add TypeFlag=>string macro
URL: https://github.com/apache/incubator-mxnet/pull/16881#issuecomment-571013968
Hi @haojin2
This is an automated message from the Apache Git Service.
To respond to
wkcn commented on issue #16881: Add TypeFlag=>string macro
URL: https://github.com/apache/incubator-mxnet/pull/16881#issuecomment-562069165
Hi @haojin2 , the request has been addressed. Could you please help take a
review? Thank you!
wkcn commented on issue #16881: Add TypeFlag=>string macro
URL: https://github.com/apache/incubator-mxnet/pull/16881#issuecomment-557741215
Hi @Kh4L,
mshadow is not archived. It has been a part of MXNet, and we can modify it.
https://github.com/apache/incubator-mxnet/pull/15600
wkcn commented on issue #16881: Add TypeFlag=>string macro
URL: https://github.com/apache/incubator-mxnet/pull/16881#issuecomment-557333251
I prefer to add the type name in DataType class.
https://github.com/apache/incubator-mxnet/blob/master/3rdparty/mshadow/mshadow/base.h#L321
