[GitHub] [incubator-mxnet] wkcn commented on pull request #18711: Fix (log_)softmax backward on empty ndarray

2020-07-15 Thread GitBox
wkcn commented on pull request #18711: URL: https://github.com/apache/incubator-mxnet/pull/18711#issuecomment-658726394 @mxnet-bot run ci [centos-cpu] This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] wkcn commented on pull request #18711: Fix (log_)softmax backward on empty ndarray

2020-07-15 Thread GitBox
wkcn commented on pull request #18711: URL: https://github.com/apache/incubator-mxnet/pull/18711#issuecomment-658594952 @bgawrych sorry for my mistake. We does not need to add test for legacy operator. You can add test into tests/python/unittest/test_numpy_op.py ---

[GitHub] [incubator-mxnet] wkcn commented on pull request #18711: Fix (log_)softmax backward on empty ndarray

2020-07-14 Thread GitBox
wkcn commented on pull request #18711: URL: https://github.com/apache/incubator-mxnet/pull/18711#issuecomment-658531787 Could you please add two unit-tests `softmax and log_softmax with empty ndarray` into `tests/python/unittest/test_operator.py` ? Check their backward procedure when input