[GitHub] [incubator-mxnet] yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray

2019-03-14 Thread GitBox
yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray URL: https://github.com/apache/incubator-mxnet/pull/14365#issuecomment-473136469 @eric-haibin-lin It is ready for final review. This is an automated messa

[GitHub] [incubator-mxnet] yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray

2019-03-13 Thread GitBox
yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray URL: https://github.com/apache/incubator-mxnet/pull/14365#issuecomment-472700764 > Do we still around size 0 to page size? Yes. I am not sure the reason behind the logic so I do not change it in this PR. We also

[GitHub] [incubator-mxnet] yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray

2019-03-12 Thread GitBox
yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray URL: https://github.com/apache/incubator-mxnet/pull/14365#issuecomment-472131522 @eric-haibin-lin please help review. @mxnet-label-bot update [pr-awaiting-review] -

[GitHub] [incubator-mxnet] yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray

2019-03-08 Thread GitBox
yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray URL: https://github.com/apache/incubator-mxnet/pull/14365#issuecomment-471115893 Yes, I am looking into the test failures. This is an automated message fr

[GitHub] [incubator-mxnet] yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray

2019-03-07 Thread GitBox
yuxihu commented on issue #14365: Fix memory leak for size-zero ndarray URL: https://github.com/apache/incubator-mxnet/pull/14365#issuecomment-470797391 @yifeim @apeforest @anirudh2290 please review. @mxnet-label-bot add [pr-awaiting-review] --