[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-11 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-482438509 @eric-haibin-lin The PR is ready to merge. Thanks. This is

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-11 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-482279075 @mxnet-label-bot update [Backend, pr-awaiting-merge] This

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481976023 > Please add a test which pushes an op using this C API, to ensure we don't have regressions in the future. Addressed

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481835319 @junrushao1994 Changed to C API. Please help review. This

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs

2019-04-10 Thread GitBox
yuxihu commented on issue #14615: Add MXEnginePushAsync and MXEnginePushSync C APIs URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481835181 > I wasn't suggesting a custom op but a standard nnvm op like mxnet backend ops. This can then be invoked using