[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-15 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397598153 Would appreciate a review from @marcoabreu and @lebeg. -

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-15 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397676703 @lebeg I think calling the compiler with $CC should be sufficient for CentOS, at least for the time bein

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-16 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397803518 @larroy Sounds good, we can also chat offline about if it in more detail if I've misunderstood. @

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-16 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397841274 @marcoabreu Gotcha. I think what would be useful would be to include some more information about what c

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-17 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397874485 @marcoabreu @larroy: No actually the error Pedro pointed out was a valid error. I've fixed it and am in

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-17 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397874485 @marcoabreu @larroy: No actually the error Pedro pointed out was a valid error. I've fixed it and am in

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-18 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-398210182 Any other data you want to see here @marcoabreu ? No rush on the merge but lmk if you need anything els

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-19 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-398301198 Right but why would we see speed ups before the docker cache is pushed? On Tue, Jun 19, 2018, 7:48

[GitHub] KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-19 Thread GitBox
KellenSunderland commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-398305634 Thanks man, appreciate it. I'll make sure and monitor master for a couple days and verify that the cach