[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2019-01-11 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r247128404 ## File path: src/operator/nn/mkldnn/mkldnn_slice.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2019-01-11 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r247139205 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -432,9 +429,18 @@ inline bool SliceForwardInferStorageType(con

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2019-01-11 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r247127740 ## File path: src/operator/nn/mkldnn/mkldnn_slice.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244340245 ## File path: src/operator/nn/mkldnn/mkldnn_slice-inl.h ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244341288 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -829,6 +809,31 @@ void SliceOpForward(const nnvm::NodeAttrs& a

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244341735 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -829,6 +809,31 @@ void SliceOpForward(const nnvm::NodeAttrs& a

[GitHub] TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice

2018-12-28 Thread GitBox
TaoLv commented on a change in pull request #13730: Add mkldnn OP for slice URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r244341140 ## File path: src/operator/tensor/matrix_op-inl.h ## @@ -432,7 +420,16 @@ inline bool SliceForwardInferStorageType(con