ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-460126456
@reminisce As you have concern about entropy change, I removed the parts
that for uint8 fix, as it's not the major
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-459944956
@reminisce , Thanks for review. We didn't track GPU accuracy as this PR only
for mkldnn convolution integration. GPU
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-459582509
@KellenSunderland @szha @TaoLv Comments are addressed. Please review again.
Thanks.
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-454675543
@KellenSunderland I just created 2 PRs, one for master, and another for
1.4.x branch. I'll try my best to get their
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-454661905
> Yes that's what I'd suggest as well. **I** would open a PR with API
changes you like to make and enough other
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-454659789
@KellenSunderland Good to hear this suggestion! To make the risk under
control, I suggest to open a PR for API change
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-454359907
@KellenSunderland @szha API is refactored to be backward compatible. please
review again. Thanks.
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-452135740
@KellenSunderland Really thanks for your engaged reviewing. @szha Thanks
for your good suggestion. There're 2 APIs
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-451083752
@KellenSunderland Thanks for your good suggestion. I've added your change
into this PR to try to get CI pass.
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-450706027
@KellenSunderland Thanks for reviewing this. The reason of build failure is
known, which will be fixed by
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-449634175
@yoel-shapiro PR is updated to address the issue you mentioned. Please try
again. Thanks for reporting this.
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-449629502
@yoel-shapiro Thanks for trying MKLDNN int8 solution. Did you apply this PR?
This PR removed line 346 check, and did
ZhennanQin commented on issue #13697: [MKLDNN] Enable signed int8 support for
convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#issuecomment-448973617
@marcoabreu Looks like CI has trouble to build this PR. Some builds failed
to compile this line
13 matches
Mail list logo
