[GitHub] ZhennanQin commented on issue #13729: [Don't merge] check CI

2018-12-28 Thread GitBox
ZhennanQin commented on issue #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#issuecomment-450449780 @apeforest mshadow PR is created at https://github.com/dmlc/mshadow/pull/367, please help to merge it. Then I will edit this PR. Thanks. --

[GitHub] ZhennanQin commented on issue #13729: [Don't merge] check CI

2018-12-27 Thread GitBox
ZhennanQin commented on issue #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#issuecomment-450286600 @apeforest CI can pass after changing back to return size_t. The corresponding MXNet change are shown as this PR. If this solution is OK. I will fil

[GitHub] ZhennanQin commented on issue #13729: [Don't merge] check CI

2018-12-25 Thread GitBox
ZhennanQin commented on issue #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#issuecomment-449900201 https://github.com/dmlc/mshadow/pull/359 this PR introduces this issue. This is an a

[GitHub] ZhennanQin commented on issue #13729: [Don't merge] check CI

2018-12-25 Thread GitBox
ZhennanQin commented on issue #13729: [Don't merge] check CI URL: https://github.com/apache/incubator-mxnet/pull/13729#issuecomment-449888266 @apeforest why mshadow::Shape::size() returns index_t instead of size_t? This will cause trouble when comparing it with other size() returns. Just as