[GitHub] ankkhedia commented on issue #12904: support upper triangular matrices in linalg

2018-11-02 Thread GitBox
ankkhedia commented on issue #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#issuecomment-435533841 > @asmushetzel seems that the OSX Travis build is failing. Can you look into it? @lupesko Travis build is not a blocker fo

[GitHub] ankkhedia commented on issue #12904: support upper triangular matrices in linalg

2018-11-02 Thread GitBox
ankkhedia commented on issue #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#issuecomment-435440556 @sandeep-krishnamurthy @nswamy Could you please take a look and merge this PR if it looks good.

[GitHub] ankkhedia commented on issue #12904: support upper triangular matrices in linalg

2018-11-01 Thread GitBox
ankkhedia commented on issue #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#issuecomment-435156110 It seems like this PR will solve the issue https://github.com/apache/incubator-mxnet/pull/13081 -

[GitHub] ankkhedia commented on issue #12904: support upper triangular matrices in linalg

2018-11-01 Thread GitBox
ankkhedia commented on issue #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#issuecomment-435155266 @asmushetzel Could you plese retrigger the CI by an empty commit. The error might be flaky and may not come up again if you re-tr

[GitHub] ankkhedia commented on issue #12904: support upper triangular matrices in linalg

2018-11-01 Thread GitBox
ankkhedia commented on issue #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#issuecomment-435130918 @asmushetzel Could you please look into CI failure. At first glance, it looks like failure in Scala package. if the error seems t

[GitHub] ankkhedia commented on issue #12904: support upper triangular matrices in linalg

2018-10-30 Thread GitBox
ankkhedia commented on issue #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#issuecomment-434458817 @sandeep-krishnamurthy This PR looks good. Could you please add pr-waiting-merge and merge it. -

[GitHub] ankkhedia commented on issue #12904: support upper triangular matrices in linalg

2018-10-29 Thread GitBox
ankkhedia commented on issue #12904: support upper triangular matrices in linalg URL: https://github.com/apache/incubator-mxnet/pull/12904#issuecomment-434097505 @mseeger Could you please review it again to see if all the comments has been addressed. @marcoabreu @lebeg @larroy It see