[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r165204667 ## File path: tests/cpp/operator/batchnorm_test.cc ## @@ -24,11 +24,14 @@ * \author Chris Olivier */

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r161617636 ## File path: Jenkinsfile ## @@ -4,6 +4,7 @@ // mxnet libraries mx_lib = 'lib/libmxnet.so,

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156219111 ## File path: include/mxnet/ndarray.h ## @@ -35,12 +35,12 @@ #include #include #include +#if

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r155818915 ## File path: include/mxnet/ndarray.h ## @@ -35,12 +35,12 @@ #include #include #include +#if

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r155819722 ## File path: prepare_mkldnn.sh ## @@ -0,0 +1,121 @@ +#!/bin/bash + +# Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r155821751 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -208,155 +127,127 @@ class BatchNormOp : public

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r155819361 ## File path: include/mxnet/ndarray.h ## @@ -820,20 +798,14 @@ class NDArray { // storage shape is also

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN

cjolivier01 commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r155819873 ## File path: python/mxnet/ndarray/mkldnn.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153384405 ## File path: src/operator/nn/cudnn/cudnn_batch_norm.cu ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153384405 ## File path: src/operator/nn/cudnn/cudnn_batch_norm.cu ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153383825 ## File path: src/operator/nn/cudnn/cudnn_batch_norm.cu ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153383825 ## File path: src/operator/nn/cudnn/cudnn_batch_norm.cu ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153383825 ## File path: src/operator/nn/cudnn/cudnn_batch_norm.cu ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r15335 ## File path: src/operator/nn/cudnn/cudnn_batch_norm.cu ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153377216 ## File path: src/operator/nn/batch_norm.cc ## @@ -313,45 +314,76 @@ void BatchNormOp

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153377261 ## File path: src/operator/nn/batch_norm.cc ## @@ -313,45 +314,76 @@ void BatchNormOp

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r153356747 ## File path: src/operator/nn/batch_norm.cc ## @@ -313,45 +314,76 @@ void BatchNormOp

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150338088 ## File path: src/operator/nn/batch_norm.cc ## @@ -313,45 +314,76 @@ void BatchNormOp

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150132538 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -176,124 +162,80 @@ class FullyConnectedOp : public Operator

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150132213 ## File path: src/operator/nn/activation-inl.h ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150128954 ## File path: src/operator/nn/activation-inl.h ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150101898 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -212,150 +212,43 @@ class BatchNormOp : public Operator { }; //

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150100174 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -117,19 +111,11 @@ class FullyConnectedOp : public Operator

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r15008 ## File path: tests/python/unittest/test_operator.py ## @@ -967,7 +967,7 @@ def check_batchnorm_training(stype):

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150098376 ## File path: src/operator/nn/activation-inl.h ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150097483 ## File path: src/operator/nn/activation-inl.h ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150096891 ## File path: src/operator/nn/activation-inl.h ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150096849 ## File path: src/operator/nn/activation-inl.h ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150095309 ## File path: tests/python/unittest/test_operator.py ## @@ -883,7 +883,6 @@ def test_nearest_upsampling():

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150095046 ## File path: src/operator/nn/convolution.cc ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150095046 ## File path: src/operator/nn/convolution.cc ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150091717 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -46,7 +46,7 @@ namespace mxnet { namespace op { namespace

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150091869 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -157,7 +157,7 @@ class BatchNormOp : public Operator { *

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150091911 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -107,7 +107,7 @@ class BatchNormOp : public Operator { *

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150091968 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -212,150 +212,43 @@ class BatchNormOp : public Operator { }; //

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150094302 ## File path: src/operator/nn/batch_norm.cc ## @@ -313,45 +314,89 @@ void BatchNormOp

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150093227 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -212,150 +212,43 @@ class BatchNormOp : public Operator { }; //

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150093460 ## File path: src/operator/nn/batch_norm.cc ## @@ -313,45 +314,89 @@ void BatchNormOp

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150092935 ## File path: src/operator/nn/batch_norm-inl.h ## @@ -212,150 +212,43 @@ class BatchNormOp : public Operator { }; //

[GitHub] cjolivier01 commented on a change in pull request #8302: Refactor operators

cjolivier01 commented on a change in pull request #8302: Refactor operators URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r150090203 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -176,124 +162,80 @@ class FullyConnectedOp : public Operator