[GitHub] cjolivier01 commented on issue #9329: Add CMake CI build job

2018-01-16 Thread GitBox
cjolivier01 commented on issue #9329: Add CMake CI build job URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-358056226 Ok, do a CUDA+CUDNN non-MKL build if possible, to get the maximum coverage of what's already in there. --

[GitHub] cjolivier01 commented on issue #9329: Add CMake CI build job

2018-01-15 Thread GitBox
cjolivier01 commented on issue #9329: Add CMake CI build job URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-357818368 With the -q (quick) argument when running unit tests, all tests run in 1 minute, 20 seconds on my weak desktop machine --

[GitHub] cjolivier01 commented on issue #9329: Add CMake CI build job

2018-01-15 Thread GitBox
cjolivier01 commented on issue #9329: Add CMake CI build job URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-357817926 Probably 'make test' should be part of every Makefile build, or at least listed as a target -

[GitHub] cjolivier01 commented on issue #9329: Add CMake CI build job

2018-01-15 Thread GitBox
cjolivier01 commented on issue #9329: Add CMake CI build job URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-357795077 These tests don't take very long to run. They should be built with every config and run as part of one of the other test suites, I imagine.

[GitHub] cjolivier01 commented on issue #9329: Add CMake CI build job

2018-01-14 Thread GitBox
cjolivier01 commented on issue #9329: Add CMake CI build job URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-357524415 c++ unit tests can be build with the Makefile as well, they?re running as part of all build configurations, right? they do check things based upon cud

[GitHub] cjolivier01 commented on issue #9329: Add CMake CI build job

2018-01-14 Thread GitBox
cjolivier01 commented on issue #9329: Add CMake CI build job URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-357523998 you?re saying this is the only build making cpp unit tests? This is an automated mess

[GitHub] cjolivier01 commented on issue #9329: Add CMake CI build job

2018-01-12 Thread GitBox
cjolivier01 commented on issue #9329: Add CMake CI build job URL: https://github.com/apache/incubator-mxnet/pull/9329#issuecomment-357354944 Is there CMAKE_BUILD_TYPE=Release set somewhere? This is an automated message from th