[GitHub] eric-haibin-lin commented on a change in pull request #14240: use safe accumulation for norm

2019-02-27 Thread GitBox
eric-haibin-lin commented on a change in pull request #14240: use safe accumulation for norm URL: https://github.com/apache/incubator-mxnet/pull/14240#discussion_r261009436 ## File path: src/operator/mxnet_op.h ## @@ -273,25 +273,42 @@ inline int get_num_threads(const int

[GitHub] eric-haibin-lin commented on a change in pull request #14240: use safe accumulation for norm

2019-02-27 Thread GitBox
eric-haibin-lin commented on a change in pull request #14240: use safe accumulation for norm URL: https://github.com/apache/incubator-mxnet/pull/14240#discussion_r261009149 ## File path: src/operator/tensor/broadcast_reduce-inl.cuh ## @@ -610,14 +609,22 @@ void ReduceImpl(

[GitHub] eric-haibin-lin commented on a change in pull request #14240: use safe accumulation for norm

2019-02-27 Thread GitBox
eric-haibin-lin commented on a change in pull request #14240: use safe accumulation for norm URL: https://github.com/apache/incubator-mxnet/pull/14240#discussion_r261009149 ## File path: src/operator/tensor/broadcast_reduce-inl.cuh ## @@ -610,14 +609,22 @@ void ReduceImpl(