[GitHub] gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace

2018-12-05 Thread GitBox
gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace URL: https://github.com/apache/incubator-mxnet/pull/13523#issuecomment-444709860 Thanks @hellonico for your work in improving this. I ran through the examples and everything looks good. It i

[GitHub] gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace

2018-12-05 Thread GitBox
gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace URL: https://github.com/apache/incubator-mxnet/pull/13523#issuecomment-444505339 It's definitely fine to change the example to make it work correctly :) I'm ok with either changing the

[GitHub] gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace

2018-12-04 Thread GitBox
gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace URL: https://github.com/apache/incubator-mxnet/pull/13523#issuecomment-444318804 Thanks for making this better! I ran some of the examples and found some bugs with the improved valida

[GitHub] gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace

2018-12-04 Thread GitBox
gigasquid commented on issue #13523: #13441 [Clojure] Add Spec Validations for the Random namespace URL: https://github.com/apache/incubator-mxnet/pull/13523#issuecomment-444212606 Thanks @hellonico ! I'll take a look shortly