[GitHub] haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-05 Thread GitBox
haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-402800500 @slitsey It's actually doable with existing layers: do an __mul_scalar first and the feed the output to normal softm

[GitHub] haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-05 Thread GitBox
haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-402808072 @slitsey I don't think it would be introducing a lot of overhead, plus we're not performing that many changes if usi

[GitHub] haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-05 Thread GitBox
haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-402814257 @slitsey Actually going in the direction I just described would require some change in the python code for SoftmaxOu

[GitHub] haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-06 Thread GitBox
haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-403153694 Well we also have the SoftmaxActivation thing... so I guess 3 new API additions then. But however we do this there'l

[GitHub] haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-06 Thread GitBox
haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-403163879 Actually something I did not mention is compatibility issues, modified APIs will have effects on the exported json f

[GitHub] haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator

2018-07-13 Thread GitBox
haojin2 commented on issue #11466: [MXNET-560] Add temperature parameter in Softmax operator URL: https://github.com/apache/incubator-mxnet/pull/11466#issuecomment-404966047 @piiswrong @reminisce @anirudh2290 @eric-haibin-lin Please give a review on this when you have time, thanks! --