[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-29 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-392743069 @zheng-da @marcoabreu , I'll modify/remove the case causing oom, meanwhile, we are working on the bugfix for the remaining fai

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-24 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-391912622 @zheng-da all the failed cases are the newly added one. I can also reproduce the failures with my own ci environment. Fo

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-23 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-391594878 @zheng-da clean-up done. Thanks @marcoabreu This is an autom

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-23 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-391381160 @marcoabreu Hi Marc, per your request I have move the newly added cases to test_gluon.py, and according to the CI result,

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-18 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-390213532 @marcoabreu Thanks for your review and kind words. These cases focusing on Gluon API, for your requests "please move them to

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-18 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-390213532 @marcoabreu Thanks for your review and kind words. These cases focusing on Gluon API, for your requests "please move them to

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-16 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-389424039 @marcoabreu @szha I checked the preci logs, and looks it is not relevant to my changes. if @zheng-da is fine with the modifica

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-15 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-389193225 @zheng-da, thanks for your time on code review, I submitted a new version addressing your comments, especially the pooling rel

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-13 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-388639656 @marcoabreu Thanks for your prompt reply. For the input shape, limited by my knowledge to mkldnn, I think it might be m

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-13 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-388622691 @marcoabreu Thanks for your comments and asking, and I fully understand your concerns on the consistence. Let me try to explai

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-13 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-388622691 @marcoabreu Thanks for your comments and asking, and I fully understand your concerns on the consistence. Let me try to explai

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-13 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-388622691 @marcoabreu Thanks for your comments and asking, and I fully understand your concerns on the consistence. Let me try to explai

[GitHub] juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon

2018-05-13 Thread GitBox
juliusshufan commented on issue #10921: Test cases improvement for MKLDNN on Gluon URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-388622691 @marcoabreu Thanks for your comments and asking, and I fully understand your concerns on the consistence. Let me try to explai