larroy commented on a change in pull request #12181: Fixed backwards 
compatibility checker
URL: https://github.com/apache/incubator-mxnet/pull/12181#discussion_r210293910
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -925,13 +925,23 @@ nightly_test_javascript() {
 nightly_model_backwards_compat_test() {
     set -ex
     export PYTHONPATH=/work/mxnet/python/
+
+    cd /work/venv
+    virtualenv -p python3
+    source /work/venv/bin/activate
 
 Review comment:
   If we do a virtualenv why not do pip install instead of exporting PYTHONPATH?
   
   Also, why not relative paths?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to