[GitHub] larroy commented on issue #8554: Disable long running tests

2017-11-09 Thread GitBox
larroy commented on issue #8554: Disable long running tests URL: https://github.com/apache/incubator-mxnet/pull/8554#issuecomment-343130514 Right @mseeger a unit test tests a unit of functionality independently, which will often correspond 1:1 to a class a function, or a single module, wit

[GitHub] larroy commented on issue #8554: Disable long running tests

2017-11-08 Thread GitBox
larroy commented on issue #8554: Disable long running tests URL: https://github.com/apache/incubator-mxnet/pull/8554#issuecomment-342789057 I think this is a good approach. I would like to see this merged. >30s or too high of resource consumption for a unit test is not acceptable.