[GitHub] marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update

2018-03-12 Thread GitBox
marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update URL: https://github.com/apache/incubator-mxnet/pull/10062#issuecomment-372279423 Ah we already got benchmarks at https://github.com/apache/incubator-mxnet/tree/master/benchmark

[GitHub] marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update

2018-03-11 Thread GitBox
marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update URL: https://github.com/apache/incubator-mxnet/pull/10062#issuecomment-372104639 By the way, could you add the benchmark at tests/python/benchmark so we can use them later on? --

[GitHub] marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update

2018-03-11 Thread GitBox
marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update URL: https://github.com/apache/incubator-mxnet/pull/10062#issuecomment-372104639 By the way, could you add the benchmark at tests/python/benchmark so we can use them leter on? --

[GitHub] marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update

2018-03-11 Thread GitBox
marcoabreu commented on issue #10062: [MXNET-72] [WIP] Improve sparse.adam_update URL: https://github.com/apache/incubator-mxnet/pull/10062#issuecomment-372104528 Very nice catch! Do you have an estimation how much overall speedup this could bring? We could highlight this in the release n