[GitHub] marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-19 Thread GitBox
marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-398302007 Oops, I forgot to take that time into account. Thank you and sorry for the inconvenience.

[GitHub] marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-18 Thread GitBox
marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-398281560 I compared the two following runs:

[GitHub] marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-17 Thread GitBox
marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397884420 Ah your PR did not change Android Arm64 because we just merged it and that caused the race condition in the

[GitHub] marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-17 Thread GitBox
marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397858157 Could you elaborate Pedro? Kellen removes the multi head in his PR while your log seems to be referencing a

[GitHub] marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-16 Thread GitBox
marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397841350 That's an excellent idea! Maybe just printing the cache hit/miss statistics after a build (not globally using

[GitHub] marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-16 Thread GitBox
marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397830325 Yes, I got the feeling that your changes are causing some builds to not use ccache anymore. It'd be good if

[GitHub] marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching

2018-06-15 Thread GitBox
marcoabreu commented on issue #11302: [MXNET-553] Restructure dockcross dockerfiles to fix caching URL: https://github.com/apache/incubator-mxnet/pull/11302#issuecomment-397740067 Great job, Kellen! Thanks a lot! I think the ccache is now not being applied to all builds. Examples: