[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-421032186 Thanks a lot! It seems like codecov is having trouble associating the proper commit hash of a PR with the report, but

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-420334683 Can you upload the content of that file on pastebin or gist? I'd love to have a closer look to investigate

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-420334067 Thanks a lot! It seems like the files are not showing up as covered here though :(

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-417775741 Have a look at the source here: https://github.com/r-lib/covr/blob/master/R/codecov.R They automatically try to

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-417611184 Do you see the publish_test_coverage call in our Jenkinsfile? It's important that this call submits the report to codecov.

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-417151134 Great, thank you. Do you want to fix that in a separate PR?

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-417141229 Thanks. Did you enable the proper error propagation? This

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-416884031 https://github.com/apache/incubator-mxnet/blob/master/ci/docker/runtime_functions.sh#L738

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-416883777 https://github.com/apache/incubator-mxnet/blob/master/Makefile#L591

[GitHub] marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package

marcoabreu commented on issue #12391: [MXNET-851] Test coverage metrics for R-package URL: https://github.com/apache/incubator-mxnet/pull/12391#issuecomment-416877104 Thank you! Could you elaborate how and when this script is getting executed? I guess we have to modify our test pipeline