[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2019-01-22 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-456510680 @szha I'm a little confused by the NNVM pass request, nGraph was one of the original targets for the subgraph design (which is

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2019-01-17 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-455385471 On an AWS C5.18xlarge instance, running `MXNET_SUBGRAPH_BACKEND="ngraph" OMP_NUM_THREADS=18 KMP_BLOCKTIME=1

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2019-01-17 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-455385166 @zheng-da We found and fixed the memory leak, benchmark_score should now run to completion. We have tested the following

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2019-01-16 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-455053262 @zheng-da Thanks for taking a look! Sorry, I've been out of a couple of days. It seems to be a memory leak, compiled graphs in

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2019-01-07 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-452014091 @zheng-da @reminisce Happy new year! Is it possible to take another look at this PR?

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2019-01-02 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-450994340 @Roshrini Rebased and pushed, thanks. This is an automated

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-11-27 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-442167469 @vandanavk still seeing Groovy errors: ``` org.codehaus.groovy.control.MultipleCompilationErrorsException: startup

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-11-13 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-438364148 @szha There appears to be a groovy error in the Jenkins job?

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-11-13 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-438363619 @zheng-da @reminisce After #12953, we're able to build nGraph with MXNet's MKLDNN such that USE_MKLDNN and USE_NGRAPH can

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-10-29 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-433958610 @zheng-da @reminisce We've added a design document here:

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-10-12 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-429395863 @reminisce If that's the preferred way to do it, I've updated the test.

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-10-11 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-429127369 Hi @eric-haibin-lin, the test failure is related to a change in the subgraph API here:

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-10-09 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-428313513 @reminisce @zheng-da Anything else you'd like to see? This is

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-10-04 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-427111685 @reminisce That makes sense, we've added some corner cases we noticed where missing from the standard unit tests, and we've

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-10-02 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-426447034 @zheng-da @reminisce Any other concerns? This is an

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-09-27 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-425278173 Thanks, @reminisce. We're prepping a blog post for release after upstreaming detailing the inference performance improvements

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-09-27 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-425231790 @reminisce What kind of examples would you like to see? After compiling with `USE_NGRAPH=1`, all Module-based examples running

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-09-26 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-424948661 @zheng-da Thanks for the review! We'll provide full responses in the morning. We added nGraph build and unit test jobs to

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-09-24 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-424148374 @eric-haibin-lin I think we have the CI system properly building with nGraph, starting to look at unit tests now. We see a

[GitHub] mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2018-09-24 Thread GitBox
mbrookhart commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-423972707 Hi Eric, We have a secondary test system working, but yeah, it would awesome to get some help setting up MXNet's CI, we