[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-24 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135177950 ## File path: python/mxnet/base.py ## @@ -359,3 +361,79 @@ def _as_list(obj): return obj

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-24 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135177950 ## File path: python/mxnet/base.py ## @@ -359,3 +361,79 @@ def _as_list(obj): return obj

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-24 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135179394 ## File path: python/mxnet/symbol/contrib.py ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Softwa

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-24 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135180860 ## File path: src/operator/tensor/la_op.cc ## @@ -32,6 +32,7 @@ DMLC_REGISTER_PARAMETER(LaMatrixM

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-25 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135330225 ## File path: python/mxnet/gluon/rnn/rnn_layer.py ## @@ -301,11 +301,11 @@ class RNN(_RNNLayer):

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-25 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135369291 ## File path: python/mxnet/ndarray/sparse.py ## @@ -41,6 +41,8 @@ from . import _internal from

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-28 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135588209 ## File path: python/mxnet/contrib/ndarray.py ## @@ -17,3 +17,4 @@ # coding: utf-8 """NDArray

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-28 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135700274 ## File path: python/mxnet/ndarray/__init__.py ## @@ -25,3 +25,6 @@ from .utils import load, sav

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-28 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135703861 ## File path: python/mxnet/ndarray/__init__.py ## @@ -25,3 +25,6 @@ from .utils import load, sav

[GitHub] reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces

2017-08-28 Thread git
reminisce commented on a change in pull request #7604: Refactor random linalg contrib namespaces URL: https://github.com/apache/incubator-mxnet/pull/7604#discussion_r135705838 ## File path: python/mxnet/ndarray/__init__.py ## @@ -17,9 +17,11 @@ """NDArray API of MXNet."