[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r164917575 ## File path: src/operator/nn/convolution-inl.h ## @@ -118,6 +118,29 @@ struct ConvolutionParam : public

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162139198 ## File path: src/operator/nn/pooling.cc ## @@ -32,67 +33,304 @@ #if MXNET_USE_NNPACK == 1 #include

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162137011 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162135856 ## File path: src/operator/nn/mkldnn/mkldnn_lrn-inl.h ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162137237 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162143059 ## File path: src/operator/nn/pooling.cc ## @@ -32,67 +33,304 @@ #if MXNET_USE_NNPACK == 1 #include

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162137778 ## File path: src/operator/nn/pooling.cc ## @@ -32,67 +33,304 @@ #if MXNET_USE_NNPACK == 1 #include

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162135731 ## File path: src/operator/nn/mkldnn/mkldnn_lrn-inl.h ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162137069 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162136358 ## File path: src/operator/lrn.cc ## @@ -1,76 +0,0 @@ -/* Review comment: Where was the code moved to?

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162135623 ## File path: src/operator/nn/mkldnn/mkldnn_lrn-inl.h ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162136660 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162135982 ## File path: src/operator/nn/mkldnn/mkldnn_lrn-inl.h ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162143003 ## File path: src/operator/nn/pooling.cc ## @@ -32,67 +33,304 @@ #if MXNET_USE_NNPACK == 1 #include

[GitHub] reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN

reminisce commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162143529 ## File path: src/operator/nn/pooling.cc ## @@ -131,8 +369,57 @@ For 3-D pooling, an additional *depth*