[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574175 ## File path: src/engine/naive_engine.cc ## @@ -73,7 +73,7 @@ class NaiveEngine final : public Engi

[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574204 ## File path: src/engine/naive_engine.cc ## @@ -125,7 +125,7 @@ class NaiveEngine final : public En

[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574053 ## File path: include/mxnet/engine.h ## @@ -182,7 +182,7 @@ class MXNET_API Engine {

[GitHub] reminisce commented on a change in pull request #9681: Better Exception Handling for Operators

2018-02-02 Thread GitBox
reminisce commented on a change in pull request #9681: Better Exception Handling for Operators URL: https://github.com/apache/incubator-mxnet/pull/9681#discussion_r165574890 ## File path: tests/python/unittest/test_exc_handling.py ## @@ -0,0 +1,112 @@ +# Licensed to the Ap