[GitHub] rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU

2018-11-27 Thread GitBox
rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU URL: https://github.com/apache/incubator-mxnet/pull/12866#discussion_r236911189 ## File path: src/operator/tensor/indexing_op.cc ## @@ -61,10 +61,14 @@ template bool

[GitHub] rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU

2018-11-27 Thread GitBox
rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU URL: https://github.com/apache/incubator-mxnet/pull/12866#discussion_r236910849 ## File path: src/operator/tensor/indexing_op.cc ## @@ -61,10 +61,14 @@ template bool

[GitHub] rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU

2018-11-27 Thread GitBox
rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU URL: https://github.com/apache/incubator-mxnet/pull/12866#discussion_r236910849 ## File path: src/operator/tensor/indexing_op.cc ## @@ -61,10 +61,14 @@ template bool

[GitHub] rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU

2018-10-29 Thread GitBox
rongzha1 commented on a change in pull request #12866: Optimization for embedding OP for CPU URL: https://github.com/apache/incubator-mxnet/pull/12866#discussion_r228833630 ## File path: src/operator/tensor/indexing_op.cc ## @@ -39,10 +39,13 @@ template bool