sandeep-krishnamurthy commented on a change in pull request #12090: [MXNET-791] Pick with negative indices URL: https://github.com/apache/incubator-mxnet/pull/12090#discussion_r210443051
########## File path: src/operator/tensor/broadcast_reduce_op.h ########## @@ -112,6 +114,14 @@ struct PickParam : public dmlc::Parameter<PickParam> { DMLC_DECLARE_FIELD(keepdims).set_default(false) .describe("If true, the axis where we pick the elements is left " "in the result as dimension with size one."); + DMLC_DECLARE_FIELD(mode) + .add_enum("wrap", kWrap) + .add_enum("clip", kClip) + .set_default(kClip) + .describe("Specify how out-of-bound indices bahave. Default is \"clip\"." Review comment: nit: bahave-> behave ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services