[GitHub] szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257104571 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -104,7 +104,8 @@

[GitHub] szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257104385 ## File path: src/operator/nn/cudnn/cudnn_pooling-inl.h ## @@ -167,102 +169,215

[GitHub] szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-14 Thread GitBox
szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r257104440 ## File path: src/operator/nn/cudnn/cudnn_pooling-inl.h ## @@ -81,7 +81,8 @@ cla

[GitHub] szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN)

2019-02-13 Thread GitBox
szha commented on a change in pull request #13749: Add NHWC layout support to Pooling (cpu, gpu cuda, gpu cuDNN) URL: https://github.com/apache/incubator-mxnet/pull/13749#discussion_r256679681 ## File path: python/mxnet/gluon/nn/conv_layers.py ## @@ -716,7 +718,8 @@ class