szha commented on a change in pull request #14173: [WIP] MXNet AMP (automatic mixed precision) URL: https://github.com/apache/incubator-mxnet/pull/14173#discussion_r258194412
########## File path: .gitmodules ########## @@ -25,7 +25,7 @@ url = https://github.com/dmlc/cub [submodule "3rdparty/tvm"] Review comment: tvm now comes with a [notice](https://github.com/dmlc/tvm/blob/master/NOTICE) file, so we'd need to add that to mxnet's notice too per apache license. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services