[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689320 Like I commented in the third comment, the naming has been fixed in #8007

[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331689054 Only when there's known bug in the code, at which time we should roll back the part with bugs.

[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331688529 Has there been known bugs or issues? If not, I'd suggest that a better path is forward, by applying the appropriate fixes. #7605 was opened a

[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331687530 For the record, I've been helping @smolix cleaning up the naming in #8007, cleaning doc in #7914.

[GitHub] szha commented on issue #8010: Revert "Many loss functions (#7605)"

2017-09-23 Thread git
szha commented on issue #8010: Revert "Many loss functions (#7605)" URL: https://github.com/apache/incubator-mxnet/pull/8010#issuecomment-331687376 Shouldn't you at least talk to the contributor before reverting this? This