[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-11-07 Thread GitBox
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-342644868 @sbodenstein From my understanding, this PR is not going to be directly merged. It's going to be merged with another revision with spars

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-10-30 Thread GitBox
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-340521591 @piiswrong @szha @sbodenstein MKL-DNN now officially supports OSX. So, we don't need to worry about this issue. https://github.com/01

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-10-20 Thread GitBox
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-338279560 @szha MKL-DNN also utilizes MKL2017. So, it would be useful to update MKL2017(2018) as well. And, the fix would be in the MXNet code. I

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-10-19 Thread GitBox
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-338058204 @szha Sure, I am looking into it. This is an automated message from the

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-10-18 Thread GitBox
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-337757546 @szha @piiswrong MKL-DNN doesn't support fp64(double) data type. Do you think this is an issue? The library team is more focusing on add

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-10-18 Thread GitBox
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-337756563 @piiswrong We have fixed convergence issue in Resnet. There were some problems in Conv and Batch norm layers. Also, we have added some m

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-10-05 Thread git
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-334575075 @eric-haibin-lin We are adding CI test same as MKLML. This is an autom

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-09-18 Thread git
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-330340158 @piiswrong Yes, MKL-DNN build passes 'test_operator.py' unit test same as MKLML build. So, we are doing several experiments. @szh

[GitHub] ykim362 commented on issue #7931: MKL-DNN integration: request for reviews

2017-09-18 Thread git
ykim362 commented on issue #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#issuecomment-330319229 @piiswrong MKL-DNN doesn't converge with Resnet. It converges with mnist. I am looking into it to find a root cause. MKLML works fine fo