[GitHub] vrahane commented on issue #599: Fix issues with logs, stats, console, reboot_log while stubbing and use req_apis for sensor drivers logs and stats

2017-10-03 Thread git
vrahane commented on issue #599: Fix issues with logs, stats, console, reboot_log while stubbing and use req_apis for sensor drivers logs and stats URL: https://github.com/apache/mynewt-core/pull/599#issuecomment-334009117 @mkiiskila and @ccollins476ad, can you please review it again, made

[GitHub] vrahane commented on issue #599: Fix issues with logs, stats, console, reboot_log while stubbing and use req_apis for sensor drivers logs and stats

2017-10-03 Thread git
vrahane commented on issue #599: Fix issues with logs, stats, console, reboot_log while stubbing and use req_apis for sensor drivers logs and stats URL: https://github.com/apache/mynewt-core/pull/599#issuecomment-334009117 @mkiiskila Can you please review it again, made a lot of changes

[GitHub] vrahane commented on issue #599: fix conditional dependencies for sensor drivers

2017-10-03 Thread git
vrahane commented on issue #599: fix conditional dependencies for sensor drivers URL: https://github.com/apache/mynewt-core/pull/599#issuecomment-333968570 Forgot that existed. Changing it. Thank you for the suggestion. This

[GitHub] mkiiskila commented on issue #599: fix conditional dependencies for sensor drivers

2017-10-03 Thread git
mkiiskila commented on issue #599: fix conditional dependencies for sensor drivers URL: https://github.com/apache/mynewt-core/pull/599#issuecomment-333965951 Maybe the following instead: pkg.req_apis: - log - stats

[GitHub] vrahane opened a new pull request #599: fix conditional dependencies for drivers

2017-10-03 Thread git
vrahane opened a new pull request #599: fix conditional dependencies for drivers URL: https://github.com/apache/mynewt-core/pull/599 - stats and logs did not have conditional dependencies in the drivers, this made it difficult for stand alone driver development. Fixing it. - Also fixing

[mynewt-core] 01/01: Merge pull request #583 from michal-narajowski/mesh-fixes

2017-10-03 Thread naraj
This is an automated email from the ASF dual-hosted git repository. naraj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 86c8f8c0c89628842c4976fdd5baa9389fc52ba3 Merge: 4437116 6e12df0 Author: Michał Narajowski

[GitHub] michal-narajowski closed pull request #583: Mesh fixes and improvements

2017-10-03 Thread git
michal-narajowski closed pull request #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rymanluk commented on a change in pull request #583: Mesh fixes and improvements

2017-10-03 Thread git
rymanluk commented on a change in pull request #583: Mesh fixes and improvements URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141806332 ## File path: net/nimble/host/mesh/src/cfg.c ## @@ -2886,18 +2886,22 @@ static void heartbeat_sub_set(struct