[GitHub] saulpw commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases

saulpw commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases URL: https://github.com/apache/mynewt-core/pull/1613#discussion_r250837466 ## File path: mgmt/imgmgr/src/imgmgr.c ## @@ -739,19 +784,32 @@ imgr_upload(struct mgmt_cbuf *cb)

[GitHub] andrzej-kaczmarek commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases

andrzej-kaczmarek commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases URL: https://github.com/apache/mynewt-core/pull/1613#discussion_r250832620 ## File path: mgmt/imgmgr/syscfg.yml ## @@ -30,6 +30,11 @@ syscfg.defs: Th

[GitHub] andrzej-kaczmarek commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases

andrzej-kaczmarek commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases URL: https://github.com/apache/mynewt-core/pull/1613#discussion_r250833190 ## File path: mgmt/imgmgr/src/imgmgr.c ## @@ -739,19 +784,32 @@ imgr_upload(struct mgmt

[GitHub] andrzej-kaczmarek commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases

andrzej-kaczmarek commented on a change in pull request #1613: Fix disconnect during OTA by spacing out erases URL: https://github.com/apache/mynewt-core/pull/1613#discussion_r250832365 ## File path: mgmt/imgmgr/src/imgmgr.c ## @@ -564,19 +606,22 @@ imgr_upload_inspect(con

[GitHub] ccollins476ad merged pull request #261: newt: Remove "imposter packages" from build graph

ccollins476ad merged pull request #261: newt: Remove "imposter packages" from build graph URL: https://github.com/apache/mynewt-newt/pull/261 This is an automated message from the Apache Git Service. To respond to the messag

[mynewt-newt] branch master updated: newt: Remove "imposter packages" from build graph

This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git The following commit(s) were added to refs/heads/master by this push: new 9bc6d19 newt: Remove "imposter packages"

[GitHub] saulpw opened a new pull request #1613: Fix disconnect during OTA by spacing out erases (#2)

saulpw opened a new pull request #1613: Fix disconnect during OTA by spacing out erases (#2) URL: https://github.com/apache/mynewt-core/pull/1613 * Erasing the entire flash image size at once can take significant time, causing a bluetooth disconnect or significant battery sag. Instead, we

[GitHub] rymanluk opened a new pull request #307: btshell: Fix controller reset on test-tx command

rymanluk opened a new pull request #307: btshell: Fix controller reset on test-tx command URL: https://github.com/apache/mynewt-nimble/pull/307 This patch fixes test-tx command which was ending with controller reset because data were send omiting bhc_outstanding_pkts needed for correc

[GitHub] ccollins476ad edited a comment on issue #260: [RFC] `$import` directive

ccollins476ad edited a comment on issue #260: [RFC] `$import` directive URL: https://github.com/apache/mynewt-newt/pull/260#issuecomment-457392854 Thanks @benmccrea, those are good questions. It turns out my testing of this feature left much to be desired; I discovered a bug while coming u

[GitHub] ccollins476ad commented on issue #260: [RFC] `$import` directive

ccollins476ad commented on issue #260: [RFC] `$import` directive URL: https://github.com/apache/mynewt-newt/pull/260#issuecomment-457392854 Thanks @benmccrea, those are good questions. It turns out my testing of this feature left much to be desired; I discovered a bug while coming up with

[GitHub] andrzej-kaczmarek merged pull request #306: nimble/host: Restore key size with existing LTK

andrzej-kaczmarek merged pull request #306: nimble/host: Restore key size with existing LTK URL: https://github.com/apache/mynewt-nimble/pull/306 This is an automated message from the Apache Git Service. To respond to the me

[mynewt-nimble] branch master updated: nimble/host: Restore key size for LTK

This is an automated email from the ASF dual-hosted git repository. andk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new e3b9d73 nimble/host: Restore key size for

[GitHub] ccollins476ad commented on issue #6: BLE reassembly support

ccollins476ad commented on issue #6: BLE reassembly support URL: https://github.com/apache/mynewt-mcumgr/issues/6#issuecomment-457310275 @bgiori Re: Write Long Characteristic Values procedure- My "BLE" is a bit rusty, so please correct me if I am wrong. During a long write procedure

[GitHub] ccollins476ad commented on issue #17: Handle unexpected poweroff

ccollins476ad commented on issue #17: Handle unexpected poweroff URL: https://github.com/apache/mynewt-nffs/issues/17#issuecomment-457293165 For the record, this is meant to work, and there are unit tests which exercise this functionality. I have not analyzed at the data in the zephyr bug

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250656047 ## File path: nimble/host/include/host/ble_gap.h ## @@ -969,23 +969,23 @@ int ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250689134 ## File path: nimble/host/src/ble_gap.c ## @@ -1355,7 +1377,7 @@ ble_gap_rx_per_adv_sync_estab(struct hci_l

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250689904 ## File path: nimble/host/src/ble_gap.c ## @@ -1388,23 +1410,33 @@ ble_gap_rx_per_adv_rpt(struct hci_le_sube

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250681768 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct hci

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250682665 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct hci

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625641 ## File path: nimble/include/nimble/hci_common.h ## @@ -984,12 +1001,23 @@ struct hci_ext_adv_params ui

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250688315 ## File path: nimble/host/include/host/ble_gap.h ## @@ -969,23 +969,23 @@ int ble_gap_ext_adv_remove(uint8_t

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250629567 ## File path: nimble/host/src/ble_hs_hci_priv.h ## @@ -235,6 +235,48 @@ ble_hs_hci_cmd_build_le_ext_adv_para

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250683320 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct hci

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625758 ## File path: nimble/include/nimble/hci_common.h ## @@ -984,12 +1001,23 @@ struct hci_ext_adv_params ui

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250695263 ## File path: nimble/host/src/ble_gap.c ## @@ -1336,14 +1336,36 @@ ble_gap_rx_adv_set_terminated(struct hci

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625027 ## File path: porting/nimble/include/syscfg/syscfg.h ## @@ -378,7 +378,7 @@ /*** nimble */ #ifndef MYNEW

[GitHub] rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature

rymanluk commented on a change in pull request #283: Adding Periodic Advertising Feature URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r250625159 ## File path: porting/nimble/include/syscfg/syscfg.h ## @@ -418,6 +418,11 @@ #define MYNEWT_VAL_BLE_ATT_PRE

[GitHub] andrzej-kaczmarek commented on issue #303: nimble/ll: Fix access address computation

andrzej-kaczmarek commented on issue #303: nimble/ll: Fix access address computation URL: https://github.com/apache/mynewt-nimble/pull/303#issuecomment-457234521 agree, although with proposed modification we do quite a lot of unnecessary bit counting. instead we can just find all transitio