[GitHub] wes3 opened a new issue #1667: NRF52 HAL: Possible SPI lockup issue if switching between blocking and non-blocking API

2019-02-27 Thread GitBox
wes3 opened a new issue #1667: NRF52 HAL: Possible SPI lockup issue if switching between blocking and non-blocking API URL: https://github.com/apache/mynewt-core/issues/1667 There is code in hal_spi_txrx() that calls hal_spi_stop_transfer(). This code presumes that if you call TASKS_STOP w

[GitHub] rymanluk merged pull request #1666: spiflash: Remove delay when reading ready status

2019-02-27 Thread GitBox
rymanluk merged pull request #1666: spiflash: Remove delay when reading ready status URL: https://github.com/apache/mynewt-core/pull/1666 This is an automated message from the Apache Git Service. To respond to the message, p

[mynewt-core] branch master updated: spiflash: Remove delay when reading ready status

2019-02-27 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 490e126 spiflash: Remove delay when reading

[GitHub] rymanluk opened a new pull request #1666: spiflash: Remove delay when reading ready status

2019-02-27 Thread GitBox
rymanluk opened a new pull request #1666: spiflash: Remove delay when reading ready status URL: https://github.com/apache/mynewt-core/pull/1666 Assume that when spiflash_wait_ready() is called in general flash should be ready, therfore while() in this function should not take long. If

[GitHub] wes3 commented on a change in pull request #1664: spiflash: Improve erase sectors

2019-02-27 Thread GitBox
wes3 commented on a change in pull request #1664: spiflash: Improve erase sectors URL: https://github.com/apache/mynewt-core/pull/1664#discussion_r260958456 ## File path: hw/drivers/flash/spiflash/src/spiflash.c ## @@ -876,6 +876,8 @@ spiflash_wait_ready(struct spiflash_de

[GitHub] andrzej-kaczmarek commented on issue #272: Fix expressions in settings restrictions

2019-02-27 Thread GitBox
andrzej-kaczmarek commented on issue #272: Fix expressions in settings restrictions URL: https://github.com/apache/mynewt-newt/pull/272#issuecomment-467987026 Good catch. No, this is definitely not an intended behavior. For now I can expand those expressions "manually", but I'll think ab

[mynewt-core] branch master updated: sys/config; allow space in stored config variables.

2019-02-27 Thread marko
This is an automated email from the ASF dual-hosted git repository. marko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 7677674 sys/config; allow space in stored c

[GitHub] mkiiskila merged pull request #1662: sys/config; allow space in stored config variables.

2019-02-27 Thread GitBox
mkiiskila merged pull request #1662: sys/config; allow space in stored config variables. URL: https://github.com/apache/mynewt-core/pull/1662 This is an automated message from the Apache Git Service. To respond to the messag

[mynewt-newt] branch master updated: Don't escape curly braces in an MSYS environment

2019-02-27 Thread ccollins
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git The following commit(s) were added to refs/heads/master by this push: new 7f01222 Don't escape curly braces in an

[GitHub] ccollins476ad merged pull request #271: Don't escape curly braces in an MSYS environment

2019-02-27 Thread GitBox
ccollins476ad merged pull request #271: Don't escape curly braces in an MSYS environment URL: https://github.com/apache/mynewt-newt/pull/271 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] ccollins476ad commented on issue #273: Allow to specify setting value range

2019-02-27 Thread GitBox
ccollins476ad commented on issue #273: Allow to specify setting value range URL: https://github.com/apache/mynewt-newt/pull/273#issuecomment-467980535 I forgot to mention - there is a missing import in `syscfg/restriction.go` (`strings`). But aside from that, the code looks good!

[GitHub] ccollins476ad edited a comment on issue #272: Fix expressions in settings restrictions

2019-02-27 Thread GitBox
ccollins476ad edited a comment on issue #272: Fix expressions in settings restrictions URL: https://github.com/apache/mynewt-newt/pull/272#issuecomment-467971712 I understand the value of this change, but I think it introduces some unintended effects. Specifically, the value `0` is now va

[GitHub] ccollins476ad commented on issue #272: Fix expressions in settings restrictions

2019-02-27 Thread GitBox
ccollins476ad commented on issue #272: Fix expressions in settings restrictions URL: https://github.com/apache/mynewt-newt/pull/272#issuecomment-467971712 I understand the value of this change, but I think it introduces some unintended effects. Specifically, the value `0` is now valid for

[GitHub] ccollins476ad commented on a change in pull request #270: Allow choice settings in syscfg

2019-02-27 Thread GitBox
ccollins476ad commented on a change in pull request #270: Allow choice settings in syscfg URL: https://github.com/apache/mynewt-newt/pull/270#discussion_r260871773 ## File path: newt/syscfg/restrict.go ## @@ -17,7 +17,7 @@ * under the License. */ -// Currently, two f

[GitHub] ccollins476ad opened a new pull request #1665: hw/scripts: Issue 2nd reset after jlink load

2019-02-27 Thread GitBox
ccollins476ad opened a new pull request #1665: hw/scripts: Issue 2nd reset after jlink load URL: https://github.com/apache/mynewt-core/pull/1665 After writing the binary to flash, reset the device a second time. Some devices seem to be stuck in a weird state when they are programmed (e.g.

[GitHub] andrzej-kaczmarek opened a new pull request #273: Allow to specify setting value range

2019-02-27 Thread GitBox
andrzej-kaczmarek opened a new pull request #273: Allow to specify setting value range URL: https://github.com/apache/mynewt-newt/pull/273 This allows to specify allowed range for numeric syscfg values in a simple way instead of requiring complex expressions. It allows for any combinations

[mynewt-core] branch master updated: spiflash: Improve erase sectors

2019-02-27 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 711d976 spiflash: Improve erase sectors

[GitHub] rymanluk merged pull request #1664: spiflash: Improve erase sectors

2019-02-27 Thread GitBox
rymanluk merged pull request #1664: spiflash: Improve erase sectors URL: https://github.com/apache/mynewt-core/pull/1664 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] andrzej-kaczmarek opened a new pull request #272: Fix expressions in settings restrictions

2019-02-27 Thread GitBox
andrzej-kaczmarek opened a new pull request #272: Fix expressions in settings restrictions URL: https://github.com/apache/mynewt-newt/pull/272 This patch makes following restrictions possible: ``` UART_1: description: 'Enable nRF52xxx UART1' value: 0 restr

[GitHub] rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors

2019-02-27 Thread GitBox
rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors URL: https://github.com/apache/mynewt-core/pull/1664#discussion_r260695609 ## File path: hw/drivers/flash/spiflash/src/spiflash.c ## @@ -1033,6 +1035,11 @@ spiflash_erase_sector(const str

[GitHub] rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors

2019-02-27 Thread GitBox
rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors URL: https://github.com/apache/mynewt-core/pull/1664#discussion_r260695609 ## File path: hw/drivers/flash/spiflash/src/spiflash.c ## @@ -1033,6 +1035,11 @@ spiflash_erase_sector(const str

[GitHub] rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors

2019-02-27 Thread GitBox
rymanluk commented on a change in pull request #1664: spiflash: Improve erase sectors URL: https://github.com/apache/mynewt-core/pull/1664#discussion_r260695609 ## File path: hw/drivers/flash/spiflash/src/spiflash.c ## @@ -1033,6 +1035,11 @@ spiflash_erase_sector(const str

[GitHub] andrzej-kaczmarek commented on a change in pull request #1664: spiflash: Improve erase sectors

2019-02-27 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1664: spiflash: Improve erase sectors URL: https://github.com/apache/mynewt-core/pull/1664#discussion_r260694273 ## File path: hw/drivers/flash/spiflash/src/spiflash.c ## @@ -1033,6 +1035,11 @@ spiflash_erase_sector(

[GitHub] rymanluk opened a new pull request #1664: spiflash: Improve erase sectors

2019-02-27 Thread GitBox
rymanluk opened a new pull request #1664: spiflash: Improve erase sectors URL: https://github.com/apache/mynewt-core/pull/1664 Each flash has known time which is needed to erase sector. Having this in mind we can wait a bit before reading status after sector erase. Note: This co

[GitHub] andrzej-kaczmarek commented on issue #270: Allow choice settings in syscfg

2019-02-27 Thread GitBox
andrzej-kaczmarek commented on issue #270: Allow choice settings in syscfg URL: https://github.com/apache/mynewt-newt/pull/270#issuecomment-467799651 fixed comments and updated description to describe current behavior This is