[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371641933 ## File path: nimble/include/nimble/hci_common.h ## @@ -825,6 +825,13 @@ struc

[mynewt-core] branch master updated: hw/mcu/dialog: Fix unitialized variable in hal_timer_stop (#2169)

2020-01-27 Thread wes3
This is an automated email from the ASF dual-hosted git repository. wes3 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new d4b3e5a hw/mcu/dialog: Fix unitialized varia

[GitHub] [mynewt-core] wes3 merged pull request #2169: hw/mcu/dialog: Fix unitialized variable in hal_timer_stop

2020-01-27 Thread GitBox
wes3 merged pull request #2169: hw/mcu/dialog: Fix unitialized variable in hal_timer_stop URL: https://github.com/apache/mynewt-core/pull/2169 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2169: hw/mcu/dialog: Fix unitialized variable in hal_timer_stop

2020-01-27 Thread GitBox
apache-mynewt-bot commented on issue #2169: hw/mcu/dialog: Fix unitialized variable in hal_timer_stop URL: https://github.com/apache/mynewt-core/pull/2169#issuecomment-578943631 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-core] wes3 opened a new pull request #2169: hw/mcu/dialog: Fix unitialized variable in hal_timer_stop

2020-01-27 Thread GitBox
wes3 opened a new pull request #2169: hw/mcu/dialog: Fix unitialized variable in hal_timer_stop URL: https://github.com/apache/mynewt-core/pull/2169 The local variable 'reset' was not initialized prior to use. This is an auto

[GitHub] [mynewt-newt] utzig commented on issue #371: Remove deprecated `install` and `sync` commands

2020-01-27 Thread GitBox
utzig commented on issue #371: Remove deprecated `install` and `sync` commands URL: https://github.com/apache/mynewt-newt/pull/371#issuecomment-578920017 @ccollins476ad Should the following docs be removed as well: `docs/command_list/newt_install.rst` and `docs/command_list/newt_sync.rst` ?

[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #373: Fix some issue reported by Coverity

2020-01-27 Thread GitBox
ccollins476ad opened a new pull request #373: Fix some issue reported by Coverity URL: https://github.com/apache/mynewt-newt/pull/373 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #737: nimble/ll: Use S=8 coding by default

2020-01-27 Thread GitBox
sjanc commented on a change in pull request #737: nimble/ll: Use S=8 coding by default URL: https://github.com/apache/mynewt-nimble/pull/737#discussion_r371431647 ## File path: nimble/controller/include/controller/ble_phy.h ## @@ -218,16 +216,14 @@ static inline int ble_ll

[mynewt-nimble] 02/04: nimble/ll: Fix adv data length calculation if SyncInfo is present

2020-01-27 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit 8f4b9b4f1b9cf2f5587e924a4aba247a7474a85c Author: Szymon Janc AuthorDate: Fri Jan 24 09:23:03 2020 +0100 nimble

[mynewt-nimble] branch master updated (9e83793 -> f44bda8)

2020-01-27 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from 9e83793 nimble/btshell: Fix build with SHELL_CMD_HELP set to 0 new 5705d6f nimble/ll: Don't put TxPower i

[mynewt-nimble] 04/04: nimble/ll: Fix misleading comment

2020-01-27 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit f44bda83101cfbe84c5dd1f1fb38b4010fbc9c44 Author: Szymon Janc AuthorDate: Fri Jan 24 09:22:54 2020 +0100 nimble

[mynewt-nimble] 01/04: nimble/ll: Don't put TxPower into AUX_CHAIN_IND PDU

2020-01-27 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit 5705d6f606206f4c8c0cb9c14e91e3c3e68f21ec Author: Szymon Janc AuthorDate: Fri Jan 24 08:54:38 2020 +0100 nimble

[mynewt-nimble] 03/04: nimble/ll: Make flags in Extended Header optional

2020-01-27 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git commit e390de8676f0a0e14b904303e2ddc294a9c9a492 Author: Szymon Janc AuthorDate: Fri Jan 24 10:51:58 2020 +0100 nimble

[GitHub] [mynewt-nimble] sjanc merged pull request #739: Support for optional TxPower in Extended Header

2020-01-27 Thread GitBox
sjanc merged pull request #739: Support for optional TxPower in Extended Header URL: https://github.com/apache/mynewt-nimble/pull/739 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [mynewt-core] vrahane edited a comment on issue #2167: LIS2DH12 Sem Time

2020-01-27 Thread GitBox
vrahane edited a comment on issue #2167: LIS2DH12 Sem Time URL: https://github.com/apache/mynewt-core/pull/2167#issuecomment-578901672 @utzig the style suggestions were good but the PR did not change the lines pointed out by the bot :-) -

[GitHub] [mynewt-core] vrahane commented on issue #2167: LIS2DH12 Sem Time

2020-01-27 Thread GitBox
vrahane commented on issue #2167: LIS2DH12 Sem Time URL: https://github.com/apache/mynewt-core/pull/2167#issuecomment-578901672 @utzig the style suggestions were good but the Pr did not change the lines pointed out by the bot :-)

[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #372: `newt info`: Include newt version at top of output

2020-01-27 Thread GitBox
ccollins476ad opened a new pull request #372: `newt info`: Include newt version at top of output URL: https://github.com/apache/mynewt-newt/pull/372 The `newt info` command displays information about each repo in the user's project. Including the newt version makes the output more useful

[GitHub] [mynewt-newt] utzig merged pull request #367: Fix clone of repos for non-[install|upgrade] cmds

2020-01-27 Thread GitBox
utzig merged pull request #367: Fix clone of repos for non-[install|upgrade] cmds URL: https://github.com/apache/mynewt-newt/pull/367 This is an automated message from the Apache Git Service. To respond to the message, pleas

[mynewt-newt] branch master updated (7e2fee5 -> e33ba77)

2020-01-27 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git. from 7e2fee5 Print OneTimeWarning errors to stderr add e33ba77 Fix clone of repos for non-[install|upgrade] cmd

[GitHub] [mynewt-newt] ccollins476ad opened a new pull request #371: Remove deprecated `install` and `sync` commands

2020-01-27 Thread GitBox
ccollins476ad opened a new pull request #371: Remove deprecated `install` and `sync` commands URL: https://github.com/apache/mynewt-newt/pull/371 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [mynewt-core] utzig commented on issue #2167: LIS2DH12 Sem Time

2020-01-27 Thread GitBox
utzig commented on issue #2167: LIS2DH12 Sem Time URL: https://github.com/apache/mynewt-core/pull/2167#issuecomment-578879004 hmmm, most of those style suggestions were actually good! This is an automated message from the Apac

[GitHub] [mynewt-newt] utzig commented on a change in pull request #367: Fix clone of repos for non-[install|upgrade] cmds

2020-01-27 Thread GitBox
utzig commented on a change in pull request #367: Fix clone of repos for non-[install|upgrade] cmds URL: https://github.com/apache/mynewt-newt/pull/367#discussion_r371396973 ## File path: newt/project/project.go ## @@ -499,16 +506,24 @@ func (proj *Project) verifyNewtCompa

[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #367: Fix clone of repos for non-[install|upgrade] cmds

2020-01-27 Thread GitBox
ccollins476ad commented on a change in pull request #367: Fix clone of repos for non-[install|upgrade] cmds URL: https://github.com/apache/mynewt-newt/pull/367#discussion_r371389019 ## File path: newt/project/project.go ## @@ -499,16 +506,24 @@ func (proj *Project) verifyN

[mynewt-newt] branch master updated (7b42efd -> 7e2fee5)

2020-01-27 Thread utzig
This is an automated email from the ASF dual-hosted git repository. utzig pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git. from 7b42efd Simplify repo dependencies add 7e2fee5 Print OneTimeWarning errors to stderr No new revisions wer

[GitHub] [mynewt-newt] utzig merged pull request #370: Print OneTimeWarning errors to stderr

2020-01-27 Thread GitBox
utzig merged pull request #370: Print OneTimeWarning errors to stderr URL: https://github.com/apache/mynewt-newt/pull/370 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [mynewt-newt] utzig commented on issue #370: [DNM] Print OneTimeWarning errors to stderr

2020-01-27 Thread GitBox
utzig commented on issue #370: [DNM] Print OneTimeWarning errors to stderr URL: https://github.com/apache/mynewt-newt/pull/370#issuecomment-578799424 @ccollins476ad Not sure about possible side-effects of changing this, but the "WARNING: apache-mynewt-core: Repo version missing from compati

[GitHub] [mynewt-nimble] sjanc merged pull request #742: the location of the two endifs was incorrect and the file did not bui…

2020-01-27 Thread GitBox
sjanc merged pull request #742: the location of the two endifs was incorrect and the file did not bui… URL: https://github.com/apache/mynewt-nimble/pull/742 This is an automated message from the Apache Git Service. To respon

[mynewt-nimble] branch master updated: nimble/btshell: Fix build with SHELL_CMD_HELP set to 0

2020-01-27 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new 9e83793 nimble/btshell: Fix build with SHE

[GitHub] [mynewt-newt] utzig closed pull request #369: [DNM] drop later

2020-01-27 Thread GitBox
utzig closed pull request #369: [DNM] drop later URL: https://github.com/apache/mynewt-newt/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mynewt-newt] utzig opened a new pull request #370: Print OneTimeWarning errors to stderr

2020-01-27 Thread GitBox
utzig opened a new pull request #370: Print OneTimeWarning errors to stderr URL: https://github.com/apache/mynewt-newt/pull/370 OneTimeWarning currently prints to `stdout`, which when warnings are found, results in test cases run in CI to fail, so update it to print to `stderr`. --

[mynewt-nimble] branch master updated: nimble/host: Fix for BLE_HS_DBG_ASSERT in adv_set_fields

2020-01-27 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new de3d69e nimble/host: Fix for BLE_HS_DBG_A

[GitHub] [mynewt-nimble] rymanluk merged pull request #743: nimble/host: Fix for BLE_HS_DBG_ASSERT in adv_set_fields

2020-01-27 Thread GitBox
rymanluk merged pull request #743: nimble/host: Fix for BLE_HS_DBG_ASSERT in adv_set_fields URL: https://github.com/apache/mynewt-nimble/pull/743 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [mynewt-mcumgr] sparkhead95 commented on issue #10: Print plain text error message rather than error code

2020-01-27 Thread GitBox
sparkhead95 commented on issue #10: Print plain text error message rather than error code URL: https://github.com/apache/mynewt-mcumgr/issues/10#issuecomment-578789719 > What means `Error: 6`? Hi @Olivier-ProGlove did you figure out how to fix `Error: 6`? I don't know what's causing

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371290662 ## File path: nimble/controller/src/ble_ll.c ## @@ -1277,6 +1280,46 @@ ble_

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371290101 ## File path: nimble/controller/src/ble_ll.c ## @@ -1277,6 +1280,46 @@ ble_

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371288697 ## File path: nimble/controller/include/controller/ble_ll.h ## @@ -199,44 +

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371273967 ## File path: nimble/controller/include/controller/ble_ll.h ## @@ -199,44 +

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371273967 ## File path: nimble/controller/include/controller/ble_ll.h ## @@ -199,44 +

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
rymanluk commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371273967 ## File path: nimble/controller/include/controller/ble_ll.h ## @@ -199,44 +

[mynewt-documentation] branch master updated: Update ble_bare_bones tutorial

2020-01-27 Thread rymek
This is an automated email from the ASF dual-hosted git repository. rymek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-documentation.git The following commit(s) were added to refs/heads/master by this push: new 50339c1 Update ble_bare_bones tuto

[GitHub] [mynewt-nimble] mlaz merged pull request #741: Set bleprph main task stack size to 512.

2020-01-27 Thread GitBox
mlaz merged pull request #741: Set bleprph main task stack size to 512. URL: https://github.com/apache/mynewt-nimble/pull/741 This is an automated message from the Apache Git Service. To respond to the message, please log on

[mynewt-nimble] branch master updated: Set bleprph main stack size to 512 so img_mgmt uploads dont overflow

2020-01-27 Thread mlaz
This is an automated email from the ASF dual-hosted git repository. mlaz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new 8161f85 Set bleprph main stack size to 512

[GitHub] [mynewt-nimble] mlaz commented on issue #741: Set bleprph main task stack size to 512.

2020-01-27 Thread GitBox
mlaz commented on issue #741: Set bleprph main task stack size to 512. URL: https://github.com/apache/mynewt-nimble/pull/741#issuecomment-578754523 > so this should be explained in commit message Commit message updated.

[GitHub] [mynewt-newt] utzig opened a new pull request #369: [DNM] drop later

2020-01-27 Thread GitBox
utzig opened a new pull request #369: [DNM] drop later URL: https://github.com/apache/mynewt-newt/pull/369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2168: [DNM] Add doxygen config for building man pages

2020-01-27 Thread GitBox
apache-mynewt-bot commented on issue #2168: [DNM] Add doxygen config for building man pages URL: https://github.com/apache/mynewt-core/pull/2168#issuecomment-578743977 ## Style check summary No suggestions at this time! --

[GitHub] [mynewt-newt] utzig opened a new pull request #368: [RFC] Add commands to build and browse man pages

2020-01-27 Thread GitBox
utzig opened a new pull request #368: [RFC] Add commands to build and browse man pages URL: https://github.com/apache/mynewt-newt/pull/368 This adds a PoC level support for `newt` to generate and browse the doxygen in man-page format. No proper error handling, etc, is currently implemented

[GitHub] [mynewt-core] utzig opened a new pull request #2168: [DNM] Add doxygen config for building man pages

2020-01-27 Thread GitBox
utzig opened a new pull request #2168: [DNM] Add doxygen config for building man pages URL: https://github.com/apache/mynewt-core/pull/2168 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371232483 ## File path: nimble/controller/include/controller/ble_ll.h ## @@

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371224178 ## File path: nimble/controller/src/ble_ll.c ## @@ -1277,6 +1280,46 @@ ble_ll_

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371224829 ## File path: nimble/controller/include/controller/ble_ll.h ## @@ -199,44 +199

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

2020-01-27 Thread GitBox
sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes. URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371223736 ## File path: nimble/controller/src/ble_ll.c ## @@ -1277,6 +1280,46 @@ ble_ll_

[GitHub] [mynewt-mcumgr] carlescufi commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample

2020-01-27 Thread GitBox
carlescufi commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample URL: https://github.com/apache/mynewt-mcumgr/pull/60#issuecomment-578712077 > As I understand @vrahane , they want to keep their copy, so I am at least updating it for them. @vrahane I disagree with

[GitHub] [mynewt-mcumgr] de-nordic commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample

2020-01-27 Thread GitBox
de-nordic commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample URL: https://github.com/apache/mynewt-mcumgr/pull/60#issuecomment-578710956 As I understand @vrahane , they want to keep their copy, so I am at least updating it for them. ---

[GitHub] [mynewt-mcumgr] carlescufi commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample

2020-01-27 Thread GitBox
carlescufi commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample URL: https://github.com/apache/mynewt-mcumgr/pull/60#issuecomment-578709260 I don't understand. This sample is maintained inside the [zephyr tree](https://github.com/zephyrproject-rtos/zephyr/tree/master/sam

[GitHub] [mynewt-mcumgr] nvlsianpu commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample

2020-01-27 Thread GitBox
nvlsianpu commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample URL: https://github.com/apache/mynewt-mcumgr/pull/60#issuecomment-578708245 > So, the problem with having one single copy is, the upstream and the forked version of mcumgr can be out of sync. I feel we should

[GitHub] [mynewt-nimble] rymanluk opened a new pull request #743: nimble/host: Fix for BLE_HS_DBG_ASSERT in adv_set_fields

2020-01-27 Thread GitBox
rymanluk opened a new pull request #743: nimble/host: Fix for BLE_HS_DBG_ASSERT in adv_set_fields URL: https://github.com/apache/mynewt-nimble/pull/743 This is regression after 95833796 nimble/host: Fix checking dst_len in adv_set_fields Function ble_hs_adv_set_fields_mbuf() does

[GitHub] [mynewt-mcumgr] de-nordic commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample

2020-01-27 Thread GitBox
de-nordic commented on issue #60: [DNM] samples: Removal of Zephyr smp_svr sample URL: https://github.com/apache/mynewt-mcumgr/pull/60#issuecomment-578641205 Lets abandon the idea about removing the sample and lets update it instead: https://github.com/apache/mynewt-mcumgr/pull/62 -

[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #62: samples/smp_svr: Update of Zephyr sample

2020-01-27 Thread GitBox
de-nordic opened a new pull request #62: samples/smp_svr: Update of Zephyr sample URL: https://github.com/apache/mynewt-mcumgr/pull/62 The Zephyr version of mcumgr/smp_svr sample has been updated with current (commit d380622a) version of source code from Zephyr repository: zephyrpoje