[GitHub] [mynewt-core] ccollins476ad merged pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
ccollins476ad merged pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[mynewt-core] branch master updated: net/oic: Fail init if any interface fails

2020-06-16 Thread ccollins
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 9d57b34 net/oic: Fail init if any

[GitHub] [mynewt-core] wes3 merged pull request #2318: hw/mcu/stm/stm32_common: Add include for os_cputime.h

2020-06-16 Thread GitBox
wes3 merged pull request #2318: URL: https://github.com/apache/mynewt-core/pull/2318 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[mynewt-core] branch master updated: hw/mcu/stm/stm32_common: Add include for os_cputime.h (#2318)

2020-06-16 Thread wes3
This is an automated email from the ASF dual-hosted git repository. wes3 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new afe3836 hw/mcu/stm/stm32_common: Add

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2318: hw/mcu/stm/stm32_common: Add include for os_cputime.h

2020-06-16 Thread GitBox
apache-mynewt-bot commented on pull request #2318: URL: https://github.com/apache/mynewt-core/pull/2318#issuecomment-644962763 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] wes3 opened a new pull request #2318: hw/mcu/stm/stm32_common: Add include for os_cputime.h

2020-06-16 Thread GitBox
wes3 opened a new pull request #2318: URL: https://github.com/apache/mynewt-core/pull/2318 The stm32_periph.c file may not include os_cputime.h if certain syscfg values are not set. This explicitly include os_cputime.h if OS_CPUTIME_TIMER_NUM is >= 0.

[GitHub] [mynewt-core] kasjer commented on pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
kasjer commented on pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317#issuecomment-644952487 Thanks for explanation. There was no objection on my part, just curiosity. This is an automated message

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317#issuecomment-644429110 ## Style check summary No suggestions at this time! This is

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
apache-mynewt-bot commented on pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317#issuecomment-644950969 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] ccollins476ad commented on pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
ccollins476ad commented on pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317#issuecomment-644948414 > I'm fine with change, this area is so distant from what I touch on daily basis that it was just curiosity. If one interface fails and that is enough to fail, why

[GitHub] [mynewt-core] kasjer commented on pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
kasjer commented on pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317#issuecomment-644939006 I'm fine with change, this area is so distant from what I touch on daily basis that it was just curiosity. If one interface fails and that is enough to fail, why try others

[GitHub] [mynewt-core] ccollins476ad commented on pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
ccollins476ad commented on pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317#issuecomment-644905537 Thanks @vrahane and @kasjer. > Code is fine, could you explain however why this is needed. If this is obvious for oic then forget I asked. I was just curious

[GitHub] [mynewt-core] kasjer commented on pull request #2317: net/oic: Fail init if any interface fails

2020-06-16 Thread GitBox
kasjer commented on pull request #2317: URL: https://github.com/apache/mynewt-core/pull/2317#issuecomment-644879420 Code is fine, could you explain however why this is needed. If this is obvious for oic then forget I asked. I was just curious why code that work OK in one way now has to be