DurandA opened a new issue #911:
URL: https://github.com/apache/mynewt-nimble/issues/911
https://github.com/apache/mynewt-nimble/blob/7b5b5e5b512133e50ef8a517b13e7269f9c821fd/apps/blehr/src/main.c#L33
Probably not an actual bug, but shouldn't `notify_state` in principle use an
`atom
kasjer commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-774317871
> @kasjer Looks good to me but needs a rebase.
@vrahane I rebased with necessary corrections, thanks for checking out.
apache-mynewt-bot removed a comment on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-731284061
## Style check summary
No suggestions at this time!
This is an
apache-mynewt-bot commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-774317539
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot commented on pull request #910:
URL: https://github.com/apache/mynewt-nimble/pull/910#issuecomment-774286632
## Style check summary
No suggestions at this time!
This is an automat
andrzej-kaczmarek opened a new pull request #910:
URL: https://github.com/apache/mynewt-nimble/pull/910
Disabling some errors temporarily to avoid tx_late does not work
properly because those errors are not reset when BS is reset and we
may still have CMAC error after those errors are
mlaz merged pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
mlaz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git.
from 1a19155 Merge pull request #2471 from benmccrea/fix-cc-alt-eventq
new fc77156 hal/mcu/nxp: Added NXP Kineti
benmccrea merged pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
benmccrea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 01d9008 charge-control: Fix to allow us
apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774187087
## Style check fail: Payload was too large
This is an automated message from the Apache Git Se
apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774141805
## Style check fail: Payload was too large
This is an automated message from the Apach
mlaz commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571145012
##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
utzig commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571134718
##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774141805
## Style check fail: Payload was too large
This is an automated message from the Apache Git Se
apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774081521
## Style check fail: Payload was too large
This is an automated message from the Apach
mlaz commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571093344
##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
utzig commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571044755
##
File path: hw/bsp/frdm-k82f/src/hal_bsp.c
##
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
kasjer commented on a change in pull request #2401:
URL: https://github.com/apache/mynewt-core/pull/2401#discussion_r571030345
##
File path: hw/mcu/dialog/da1469x/src/hal_gpio.c
##
@@ -90,6 +90,7 @@ static struct hal_gpio_irq hal_gpio_irqs[HAL_GPIO_MAX_IRQ];
#if MYNEWT_VAL(MCU
apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-774081521
## Style check fail: Payload was too large
This is an automated message from the Apache Git Se
apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-773710118
## Style check fail: Payload was too large
This is an automated message from the Apach
mlaz commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r571021811
##
File path: hw/mcu/nxp/kinetis/MK8xF/include/mcu/frdm-k8xf_hal.h
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
apache-mynewt-bot removed a comment on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774009509
## Style check summary
No suggestions at this time!
This is an
apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774018154
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774009509
## Style check summary
No suggestions at this time!
This is an automat
kasjer opened a new pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472
- MTB registers are stored in RAM when crash happens so MTB can be used
check what lead to crash
- MTB is also stopped in __assert_function() not only in default interrupt
handler
- disassemb
utzig commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r570888242
##
File path: .rat-excludes
##
@@ -291,6 +291,15 @@ fsl_clock.c
MK64FN1M0xxx12_flash.ld
boot-MK64FN1M0xxx12_flash.ld
startup_MK64F12.S
+MK82FN256xxx1
apache-mynewt-bot removed a comment on pull request #2459:
URL: https://github.com/apache/mynewt-core/pull/2459#issuecomment-765806173
This is an automated message from the Apache Git Service.
To respond to the message, please
utzig commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-773702301
This is not properly rebased, you can just drop the first two commits.
This is an automated message from the A
apache-mynewt-bot removed a comment on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-772985567
This is an automated message from the Apache Git Service.
To respond to the message, please
utzig merged pull request #2470:
URL: https://github.com/apache/mynewt-core/pull/2470
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
vrahane edited a comment on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724
Next step is merging it @jeremywood. Thank you.
This is an automated message from the Apache Git Serv
apache-mynewt-bot removed a comment on pull request #2465:
URL: https://github.com/apache/mynewt-core/pull/2465#issuecomment-772805332
## Style check summary
No suggestions at this time!
This is an
apache-mynewt-bot commented on pull request #908:
URL: https://github.com/apache/mynewt-nimble/pull/908#issuecomment-773216768
## Style check summary
No suggestions at this time!
This is an automat
utzig edited a comment on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-773691606
@mlaz I am fine with this now, please force-push again to check if no RAT
issues remain, for some reason it was no updating the message.
--
kasjer merged pull request #2439:
URL: https://github.com/apache/mynewt-core/pull/2439
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
apache-mynewt-bot commented on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-773614820
This is an automated message from the Apache Git Service.
To respond to the message, please log on
utzig merged pull request #2468:
URL: https://github.com/apache/mynewt-core/pull/2468
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
apache-mynewt-bot commented on pull request #2471:
URL: https://github.com/apache/mynewt-core/pull/2471#issuecomment-773698727
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot commented on pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463#issuecomment-773085640
## Style check summary
No suggestions at this time!
This is an automat
vrahane commented on pull request #2413:
URL: https://github.com/apache/mynewt-core/pull/2413#issuecomment-773207940
@kasjer Looks good to me but needs a rebase.
This is an automated message from the Apache Git Service.
To re
vrahane merged pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vrahane merged pull request #2459:
URL: https://github.com/apache/mynewt-core/pull/2459
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
apache-mynewt-bot removed a comment on pull request #2461:
URL: https://github.com/apache/mynewt-core/pull/2461#issuecomment-772577358
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
v01d commented on pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906#issuecomment-773359617
sorry, I missed a small change, I just force pushed. The change I added is
this:
```
diff --git a/porting/npl/nuttx/src/os_callout.c
b/porting/npl/nuttx/src/os_callout.c
apache-mynewt-bot removed a comment on pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906#issuecomment-773227350
## Style check summary
No suggestions at this time!
This is an
apache-mynewt-bot commented on pull request #2468:
URL: https://github.com/apache/mynewt-core/pull/2468#issuecomment-773084997
## Style check summary
No suggestions at this time!
This is an automat
kasjer merged pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
utzig merged pull request #2465:
URL: https://github.com/apache/mynewt-core/pull/2465
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
apache-mynewt-bot commented on pull request #2459:
URL: https://github.com/apache/mynewt-core/pull/2459#issuecomment-773218592
This is an automated message from the Apache Git Service.
To respond to the message, please log on
apache-mynewt-bot removed a comment on pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#issuecomment-772988534
This is an automated message from the Apache Git Service.
To respond to the message, please
apache-mynewt-bot commented on pull request #2461:
URL: https://github.com/apache/mynewt-core/pull/2461#issuecomment-773090058
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/
mlaz merged pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kasjer commented on pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463#issuecomment-773107660
> @kasjer LGTM. I tested with `HAL_UART: 1` and all works. There is a CI
failure (style?). I approved but I'll wait for someone else to review the CI
failure before merging.
sjanc merged pull request #908:
URL: https://github.com/apache/mynewt-nimble/pull/908
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
apache-mynewt-bot removed a comment on pull request #908:
URL: https://github.com/apache/mynewt-nimble/pull/908#issuecomment-772577803
## Style check summary
No suggestions at this time!
This is an
sjanc merged pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
apache-mynewt-bot commented on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-773567186
This is an automated message from the Apache Git Service.
To respond to the message, please log on
utzig commented on pull request #2466:
URL: https://github.com/apache/mynewt-core/pull/2466#issuecomment-773691606
@mlaz I am fine with this now, please force-push again to check if not RAT
issues remain, for some reason it was no updating the message.
vrahane commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724
Next step is merging it @jeremywood.
This is an automated message from the Apache Git Service.
To respond to
apache-mynewt-bot commented on pull request #906:
URL: https://github.com/apache/mynewt-nimble/pull/906#issuecomment-773227350
This is an automated message from the Apache Git Service.
To respond to the message, please log on
apache-mynewt-bot commented on pull request #2469:
URL: https://github.com/apache/mynewt-core/pull/2469#issuecomment-773490314
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot removed a comment on pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463#issuecomment-772578023
## Style check summary
No suggestions at this time!
This is an
apache-mynewt-bot commented on pull request #2465:
URL: https://github.com/apache/mynewt-core/pull/2465#issuecomment-773173219
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot commented on pull request #2470:
URL: https://github.com/apache/mynewt-core/pull/2470#issuecomment-773536998
## Style check summary
No suggestions at this time!
This is an automat
65 matches
Mail list logo
