[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
apache-mynewt-bot commented on pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943#issuecomment-803151166 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
apache-mynewt-bot removed a comment on pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943#issuecomment-802888387 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [mynewt-nimble] vrahane edited a comment on pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
vrahane edited a comment on pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943#issuecomment-802960761 @utzig Thanks, I think I see the issue here, nimble/controller needs to be specified as a dependency by nimble but I thought that was the apps job. `BLE_HCI_VS` shoul

[GitHub] [mynewt-nimble] vrahane commented on pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
vrahane commented on pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943#issuecomment-802960761 @utzig is it because its defined in the same file, it cannot resolve it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [mynewt-nimble] utzig commented on pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
utzig commented on pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943#issuecomment-802957117 > @sjanc The changes look fine to me, not sure why the CI is failing though. Very weird. ``` Error: Unresolved value references: BLE_HCI_VS -> Setting hist

[GitHub] [mynewt-nimble] vrahane commented on pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
vrahane commented on pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943#issuecomment-802948608 @sjanc The changes look fine to me, not sure why the CI is failing though. Very weird. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
apache-mynewt-bot commented on pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943#issuecomment-802888387 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [mynewt-nimble] sjanc opened a new pull request #943: Support for VS HCI command for reading static random address from controller

2021-03-19 Thread GitBox
sjanc opened a new pull request #943: URL: https://github.com/apache/mynewt-nimble/pull/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[mynewt-core] branch master updated: mcu/nrf5340_net: Add support for APPROTECT setup

2021-03-19 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 057f472 mcu/nrf5340_net: Add support for APP

[GitHub] [mynewt-core] sjanc merged pull request #2541: mcu/nrf5340_net: Add support for APPROTECT setup

2021-03-19 Thread GitBox
sjanc merged pull request #2541: URL: https://github.com/apache/mynewt-core/pull/2541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2538: hw/util/buzzer: Tone generator with the PWM peripheral

2021-03-19 Thread GitBox
apache-mynewt-bot commented on pull request #2538: URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-802717281 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2538: hw/util/buzzer: Tone generator with the PWM peripheral

2021-03-19 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2538: URL: https://github.com/apache/mynewt-core/pull/2538#issuecomment-802401394 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2541: mcu/nrf5340_net: Add support for APPROTECT setup

2021-03-19 Thread GitBox
apache-mynewt-bot commented on pull request #2541: URL: https://github.com/apache/mynewt-core/pull/2541#issuecomment-802664989 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) hw/

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #941: ble_sm: add Secure Connections Only mode

2021-03-19 Thread GitBox
apache-mynewt-bot removed a comment on pull request #941: URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-802631404 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #941: ble_sm: add Secure Connections Only mode

2021-03-19 Thread GitBox
apache-mynewt-bot commented on pull request #941: URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-802640427 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nim

[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #941: ble_sm: add Secure Connections Only mode

2021-03-19 Thread GitBox
KKopyscinski commented on pull request #941: URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-802639229 Test results and configs used in tests 'BLE_SM_LEGACY': '0', 'BLE_SM_SC': '1', 'BLE_SM_SC_ONLY': '0', 'BLE_SM_SC_LVL': '4', 1/8 GAP G

[GitHub] [mynewt-core] sjanc opened a new pull request #2541: mcu/nrf5340_net: Add support for APPROTECT setup

2021-03-19 Thread GitBox
sjanc opened a new pull request #2541: URL: https://github.com/apache/mynewt-core/pull/2541 This is required for enabling debugging support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #941: ble_sm: add Secure Connections Only mode

2021-03-19 Thread GitBox
KKopyscinski commented on pull request #941: URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-802632305 Corrected SC only keysize check, as it should return BLE_SM_ERR_ENC_KEY_SZ, not BLE_SM_ERR_AUTHREQ. It also should be checked before SC/legacy and MITM -- This is an

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #941: ble_sm: add Secure Connections Only mode

2021-03-19 Thread GitBox
apache-mynewt-bot removed a comment on pull request #941: URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-801920937 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #941: ble_sm: add Secure Connections Only mode

2021-03-19 Thread GitBox
apache-mynewt-bot commented on pull request #941: URL: https://github.com/apache/mynewt-nimble/pull/941#issuecomment-802631404 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) nim

[mynewt-core] 04/04: bsp/nordic_pca10095: Add QSPI flash

2021-03-19 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit cf00352c09c9638e04c7feac7171138a65ea76c1 Author: Jerzy Kasenberg AuthorDate: Thu Mar 18 13:52:42 2021 +0100 bsp/

[mynewt-core] branch master updated (88323a5 -> cf00352)

2021-03-19 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 88323a5 Merge pull request #2540 from vikrant-proxy/nrf53/spi-periph-fix new bc4a322 mcu/nrf5340: Update s

[mynewt-core] 03/04: mcu/nrf5340: Add support for QSPI flash

2021-03-19 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 9842b3f43ca1470c89f8146ebf2d915629641403 Author: Jerzy Kasenberg AuthorDate: Thu Mar 18 13:42:20 2021 +0100 mcu/

[mynewt-core] 02/04: mcu/nrf5340: Add HFCLK192M divider initialization

2021-03-19 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 8825d0b7374371438e5a0723a1a92e3f19201d34 Author: Jerzy Kasenberg AuthorDate: Thu Mar 18 13:22:30 2021 +0100 mcu/

[GitHub] [mynewt-core] sjanc merged pull request #2539: Add QSPI for NRF5340

2021-03-19 Thread GitBox
sjanc merged pull request #2539: URL: https://github.com/apache/mynewt-core/pull/2539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[mynewt-core] 01/04: mcu/nrf5340: Update system_nrf5340.c to nrfx 2.4

2021-03-19 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit bc4a322960ca0d0ee0476319d9f0dbc569298205 Author: Jerzy Kasenberg AuthorDate: Thu Mar 18 13:18:00 2021 +0100 mcu/

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #942: transport/usb: Fix len comparison to allow fragmented acl

2021-03-19 Thread GitBox
apache-mynewt-bot commented on pull request #942: URL: https://github.com/apache/mynewt-nimble/pull/942#issuecomment-802618821 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [mynewt-nimble] ncasaril opened a new pull request #942: transport/usb: Fix len comparison to allow fragmented acl

2021-03-19 Thread GitBox
ncasaril opened a new pull request #942: URL: https://github.com/apache/mynewt-nimble/pull/942 The comparison previously always triggered on the first fragment received as the expected length (len) is always larger or equal to the total received length (om_len). Partly addresse

[GitHub] [mynewt-nimble] ncasaril commented on issue #940: blehci-usb app fails on assert when trying to upload an image using newtmgr

2021-03-19 Thread GitBox
ncasaril commented on issue #940: URL: https://github.com/apache/mynewt-nimble/issues/940#issuecomment-802604554 One step closer :) This comparison is going in the wrong direction. The data should be sent if the actual data (om_len) is greater or equal to the expected length (len):