sada45 commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183854288
Yes, that sounds reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andrzej-kaczmarek commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183559883
Checking SN in `ble_ll_conn_rx_isr_end` does only mean that previously txd
PDU was acked, but the spec does not say anything about acking, it just states
that a valid
andrzej-kaczmarek commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183554896
The spec does not say anything about acking, it just states that a valid
non-empty PDU has to be txd/rxd:
`has_nonempty_pdu` is updated in `ble_ll_conn_rx_d
apache-mynewt-bot commented on PR #1297:
URL: https://github.com/apache/mynewt-nimble/pull/1297#issuecomment-1183440442
## Style check summary
No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
sada45 commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183349582
@andrzej-kaczmarek I have some doubts that wether the `has_nonempty_pdu`
should be set before or after the packet is acked.
For me, I update the `last_data_pdu` in `ble_ll_con
andrzej-kaczmarek commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1183325249
@sada45 I reworked continuation events handling a bit more, it should be
easier to understand now and I believe it should now be handled properly. let
me know how it
apache-mynewt-bot commented on PR #1297:
URL: https://github.com/apache/mynewt-nimble/pull/1297#issuecomment-1183050539
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/cont
sada45 commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182959619
I am happy that helps!
I take a look at the fix. I think there is one more bug.
When checking the continuation number, it should ignore the connection
events before the la
andrzej-kaczmarek commented on issue #1291:
URL: https://github.com/apache/mynewt-nimble/issues/1291#issuecomment-1182943669
@sada45 good catch, thanks. I created a fix for both
https://github.com/apache/mynewt-nimble/pull/1297.
I still need to validate those more carefully since appa
andrzej-kaczmarek opened a new pull request, #1297:
URL: https://github.com/apache/mynewt-nimble/pull/1297
Continuation events shall be only applied if the next event is not a
subrated event. Also the event counter shall be also updated only for
events with non-empty PDUs received.
FARLY7 commented on issue #185:
URL: https://github.com/apache/mynewt-newtmgr/issues/185#issuecomment-1182875958
+1 for the patch provided by @LockeKK.
I was able to reduce the upload times down from 3.5mins to 44s:
Original at 115,200 baud:
`247.23 KiB / 247.23 KiB [
11 matches
Mail list logo
