Re: [PR] host/ble_gap.c : Check allowed random address [mynewt-nimble]

2023-10-09 Thread via GitHub
sjanc commented on PR #1611: URL: https://github.com/apache/mynewt-nimble/pull/1611#issuecomment-1754526638 I think this should be in some common code eg ble_hs_id.c ? Some helpers for generating and internal helpers for validating type of addresses. There are similar checks for static r

Re: [PR] host: Add support for LE Set Data Related Address change command [mynewt-nimble]

2023-10-09 Thread via GitHub
sjanc commented on PR #1599: URL: https://github.com/apache/mynewt-nimble/pull/1599#issuecomment-1754504325 Hi, Why not put this configuration in advertising parameters and handle it there? Instead of adding dedicated API that just wraps HCI command -- This is an automated message

[mynewt-nimble] branch master updated: nimble/host: Fix not handling error on RL element removal

2023-10-09 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new d7950095 nimble/host: Fix not handling erro

Re: [PR] fix(nimble): Handled error return value while removing RPA list from … [mynewt-nimble]

2023-10-09 Thread via GitHub
sjanc merged PR #1605: URL: https://github.com/apache/mynewt-nimble/pull/1605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[mynewt-nimble] branch master updated: nimble/host: Add support to send power control event in registered callback

2023-10-09 Thread janc
This is an automated email from the ASF dual-hosted git repository. janc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new bf3f9503 nimble/host: Add support to send p

Re: [PR] nimble/host: Add support to send power control event in registered callback [mynewt-nimble]

2023-10-09 Thread via GitHub
sjanc merged PR #1490: URL: https://github.com/apache/mynewt-nimble/pull/1490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

Re: [PR] host/ble_gap.c : Check allowed random address [mynewt-nimble]

2023-10-09 Thread via GitHub
rahult-github commented on PR #1611: URL: https://github.com/apache/mynewt-nimble/pull/1611#issuecomment-1754429565 Hi @sjanc , can you please review this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] nimble/host: Add support to send power control event in registered callback [mynewt-nimble]

2023-10-09 Thread via GitHub
rahult-github commented on PR #1490: URL: https://github.com/apache/mynewt-nimble/pull/1490#issuecomment-1754366091 Hi @sjanc , can you please merge this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] host: Add support for LE Set Data Related Address change command [mynewt-nimble]

2023-10-09 Thread via GitHub
rahult-github commented on PR #1599: URL: https://github.com/apache/mynewt-nimble/pull/1599#issuecomment-1754366211 @sjanc , can you please take a look as have rebased the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[mynewt-core] branch master updated: hw/usb/tinyusb: Fix sysinit levels so that tinyusb gets initialized before console uses it

2023-10-09 Thread vipulrahane
This is an automated email from the ASF dual-hosted git repository. vipulrahane pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 1050faeac hw/usb/tinyusb: Fix sysinit

Re: [PR] hw/usb/tinyusb: usb cdc console and tinyusb library sysinit before console uses it [mynewt-core]

2023-10-09 Thread via GitHub
vrahane merged PR #3090: URL: https://github.com/apache/mynewt-core/pull/3090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

Re: [PR] hw/usb/tinyusb: usb cdc console and tinyusb library sysinit before console uses it [mynewt-core]

2023-10-09 Thread via GitHub
vrahane commented on PR #3090: URL: https://github.com/apache/mynewt-core/pull/3090#issuecomment-1753581552 @andrzej-kaczmarek Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[mynewt-nimble] branch master updated: host/sm: Add CSIS SIRK encryption

2023-10-09 Thread andk
This is an automated email from the ASF dual-hosted git repository. andk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git The following commit(s) were added to refs/heads/master by this push: new f2cb1ec9 host/sm: Add CSIS SIRK encryption

Re: [PR] host/sm: Add CSIS SIRK encryption [mynewt-nimble]

2023-10-09 Thread via GitHub
andrzej-kaczmarek merged PR #1635: URL: https://github.com/apache/mynewt-nimble/pull/1635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

Re: [PR] hw/usb/tinyusb: usb cdc console and tinyusb library sysinit before console uses it [mynewt-core]

2023-10-09 Thread via GitHub
andrzej-kaczmarek commented on PR #3090: URL: https://github.com/apache/mynewt-core/pull/3090#issuecomment-1752639326 lgtm, but please fix the commit message. also the same restriction added in two different places is redundant. -- This is an automated message from the Apache Git Service.